From 124b65eef5cc0394fcba6398091e3307121332c8 Mon Sep 17 00:00:00 2001
From: Mark Tompsett <mtompset@hotmail.com>
Date: Fri, 1 Sep 2017 13:16:43 -0400
Subject: [PATCH] Bug 19235: Password entry visible in OPAC Self-registration

The HTML code was "text" instead of "password".

TEST PLAN
----------
1) 'Allow' PatronSelfRegistration system preference
2) Define the PatronSelfRegistrationDefaultCategory system preference (e.g. PT)
3) Open OPAC
4) Click 'Register here' on the right.  (/cgi-bin/koha/opac-memberentry.pl)
5) Scroll to bottom
6) enter some passwords
   -- visible
7) apply this patch
8) refresh page
9) repeat 5-6 as needed
   -- passwords should not be visible while entering
10) run koha qa test tools

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 99e691feee5ef29bbc9d24a916fc4aa2fab6bba6)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit b7856f76af9e0bbef7dca6458c8074710a309ca8)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
---
 .../opac-tmpl/bootstrap/en/modules/opac-memberentry.tt    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
index 53401b966e..02acab9512 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
@@ -864,21 +864,21 @@
                         [% IF mandatory.defined('password') %]
                             <ol>
                                 <li><label for="borrower_password" class="required">Password</label>
-                                    <input type="text" name="borrower_password" id="password" />
+                                    <input type="password" name="borrower_password" id="password" />
                                     <span class="required">Required</span>
                                 </li>
                                 <li><label for="borrower_password2" class="required">Confirm password</label>
-                                    <input type="text" name="borrower_password2" id="password2" />
+                                    <input type="password" name="borrower_password2" id="password2" />
                                     <span class="required">Required</span>
                                 </li>
                             </ol>
                         [% ELSE %]
                             <ol>
                                 <li><label for="borrower_password">Password</label>
-                                    <input type="text" name="borrower_password" id="password" />
+                                    <input type="password" name="borrower_password" id="password" />
                                 </li>
                                 <li><label for="borrower_password2">Confirm password</label>
-                                    <input type="text" name="borrower_password2" id="password2" />
+                                    <input type="password" name="borrower_password2" id="password2" />
                                 </li>
                             </ol>
                         [% END %]
-- 
2.39.5