From 706e7a953e07b8c143a1308e45f6211aae18c6b7 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Mon, 20 Oct 2014 12:36:36 +0200 Subject: [PATCH] Bug 13204: Plugin housekeeping: Remove labs_theses.pl plugin As it seems, this plugin has been created for UNIMARC field 328 (Dissertation note). It refers to authval category LABTHE. The plugin seems however not to be used: it contains several critical errors. I tried a quick fix but it was not good enough. Since the code can be recovered from git (if needed), a real fix can always follow this patch. What are some problems: [1] The path to the template is wrong. Should be cataloguing/value_builder [2] The plugin parameter $input is not used. A new CGI object is created. [3] Resolving errors 1 and 2 still results in premature end of script headers. [4] Not sure whether the plugin can effectively handle missing LABTHE values. Instead of keeping this in Koha, I opt for removing it for now. As additional argument I would mention that labs_theses does not have Focus or Blur actions, only the Click action that does not work. Test plan: Git grep on labs_theses. Signed-off-by: Frederic Demians This antique plugin deserves to live forever in Git Historical Museum. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Small fix so the patch applies. --- cataloguing/value_builder/labs_theses.pl | 188 ------------------ .../cataloguing/value_builder/labs_theses.tt | 122 ------------ 2 files changed, 310 deletions(-) delete mode 100755 cataloguing/value_builder/labs_theses.pl delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/labs_theses.tt diff --git a/cataloguing/value_builder/labs_theses.pl b/cataloguing/value_builder/labs_theses.pl deleted file mode 100755 index 313f66ad00..0000000000 --- a/cataloguing/value_builder/labs_theses.pl +++ /dev/null @@ -1,188 +0,0 @@ -#!/usr/bin/perl - -# Copyright 2000-2002 Katipo Communications -# -# This file is part of Koha. -# -# Koha is free software; you can redistribute it and/or modify it under the -# terms of the GNU General Public License as published by the Free Software -# Foundation; either version 2 of the License, or (at your option) any later -# version. -# -# Koha is distributed in the hope that it will be useful, but WITHOUT ANY -# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR -# A PARTICULAR PURPOSE. See the GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with Koha; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - -use strict; -#use warnings; FIXME - Bug 2505 - -use CGI qw ( -utf8 ); - -use C4::Output; -use C4::Context; -use C4::Auth; -use C4::Output; - -use C4::Koha; - -sub plugin_parameters { -my ($dbh,$record,$tagslib,$i,$tabloop) = @_; -return ""; -} - -sub plugin_javascript { -my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; -my $function_name= "328".(int(rand(100000))+1); -my $res=" - -"; - -return ($function_name,$res); -} - -sub plugin { - my ($input) = @_; - my $dbh=C4::Context->dbh; - my $query = new CGI; - my $op = $query->param('op'); - my $cat_auth=$query->param('cat_auth'); - - my $startfrom=$query->param('startfrom'); - $startfrom=0 if(!defined $startfrom); - my ($template, $loggedinuser, $cookie); - my $resultsperpage; - my $search = $query->param('search'); - - if ($op eq "do_search") { - - $resultsperpage= $query->param('resultsperpage'); - $resultsperpage = 19 if(!defined $resultsperpage); -# my $upperlimit=$startfrom+$resultsperpage; - # builds tag and subfield arrays - my $strquery = "SELECT authorised_value, lib from authorised_values where category = ? and lib like ?"; -# $strquery .= " LIMIT $startfrom,$upperlimit"; - - $search=~s/\*/%/g; - my $sth = $dbh->prepare($strquery); - $sth->execute($cat_auth,$search); - $search=~s/%/\*/g; - - - my @results; - my $total; - while (my $data = $sth->fetchrow_hashref){ - my $libjs=$data->{'lib'}; - $libjs=~s#\'#\\\'#g; - my $authjs=$data->{'authorised_value'}; - $authjs=~s#\'#\\\'#g; - push @results, {'libjs'=>$libjs, - 'lib'=>$data->{'lib'}, - 'authjs'=>$authjs, - 'auth_value'=>$data->{'authorised_value'}} - unless (($total<$startfrom) or ($total>$startfrom+$resultsperpage)); - $total++; - } - - ($template, $loggedinuser, $cookie) = get_template_and_user( - { - template_name => "value_builder/labs_theses.tt", - query => $query, - type => 'intranet', - authnotrequired => 0, - debug => 1, - } - ); - - # multi page display gestion - my $displaynext=0; - my $displayprev=$startfrom; - if(($total - (($startfrom+1)*($resultsperpage))) > 0 ){ - $displaynext = 1; - } - - my @numbers = (); - - if ($total>$resultsperpage) - { - for (my $i=1; (($i<$total/$resultsperpage+1) && ($i<16)); $i++) - { - my $highlight=0; - ($startfrom==($i-1)) && ($highlight=1); - push @numbers, { number => $i, - highlight => $highlight , - search=> $search, - startfrom => $resultsperpage*($i-1)}; - } - } - - my $from = $startfrom+1; - my $to; - - if($total < (($startfrom+1)*$resultsperpage)) - { - $to = $total; - } else { - $to = (($startfrom+1)*$resultsperpage); - } - $template->param(catresult => \@results, - cat_auth=>$cat_auth, - index => $query->param('index')."", - startfrom=> $startfrom, - displaynext=> $displaynext, - displayprev=> $displayprev, - resultsperpage => $resultsperpage, - startfromnext => $startfrom+$resultsperpage, - startfromprev => $startfrom-$resultsperpage, - search=>$search, - total=>$total, - from=>$from, - to=>$to, - numbers=>\@numbers, - resultlist=>1 - ); - - } else { - ($template, $loggedinuser, $cookie) = get_template_and_user( - { - template_name => "value_builder/labs_theses.tt", - query => $query, - type => "intranet", - authnotrequired => 0, - } - ); - - $template->param( - 'search'=>$query->param('search'), - ); - $template->param( - 'index'=>''.$query->param('index') - ) if ($query->param('index')); - $template->param( - 'cat_auth'=>$cat_auth - ) if ($cat_auth); - } - output_html_with_http_headers $query, $cookie, $template->output ; -} - -1; diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/labs_theses.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/labs_theses.tt deleted file mode 100644 index 2162747338..0000000000 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/labs_theses.tt +++ /dev/null @@ -1,122 +0,0 @@ -[% INCLUDE 'doc-head-open.inc' %] -Koha › Labs thesis selection plugin -[% INCLUDE 'doc-head-close.inc' %] - - - - - - - -
-

Laboratory search

- -
-
-

Search on

-

- - - - - - - - -

-
-
- -[% IF ( resultlist ) %] -
-

Laboratory search results

-
-

- [% IF ( total ) %] - Results [% from %] to [% to %] of [% total %][% ELSE %]No results found - [% END %] -

-
-
- - - - - - [% FOREACH catresul IN catresult %] - [% IF ( catresul.even ) %] - - [% ELSE %] - - [% END %] - - - - [% END %] -
LaboratorySelect
- [% catresul.lib %] - - Select - Sel&close -
-
-
-

[% IF ( displayprev ) %] - << Previous - [% END %] - [% FOREACH number IN numbers %] - [% IF ( number.highlight ) %] - [% number.number %] - [% ELSE %] - [% number.number %] - [% END %] - [% END %] - [% IF ( displaynext ) %] - Next>> - [% END %] -

-

- [% IF ( total ) %] - Results [% from %] to [% to %] of [% total %][% ELSE %]No results found - [% END %] -

-
- -
-[% END %] -
-[% INCLUDE 'popup-bottom.inc' %] -- 2.39.5