]> git.koha-community.org Git - koha.git/commit
Bug 23681: Fix QA issues
authorEmmi Takkinen <emmi.takkinen@koha-suomi.fi>
Mon, 2 May 2022 12:40:35 +0000 (15:40 +0300)
committerTomas Cohen Arazi <tomascohen@theke.io>
Thu, 25 Aug 2022 11:41:05 +0000 (08:41 -0300)
commit20349d87379dc6f66290050c0b7c2beaf6763c06
tree1aaab7d7882bedb6cd528459f1bcebf1590c2eec
parenteb28de78fe0e05b3496e28ba10f375fc7bacff92
Bug 23681: Fix QA issues

This patch fixes following QA issues:
- convert intaller files as .yml
- change column name readonly as is_system
- change column name is_system as default_value
- add column can_be_added_manually (testplan for this below)
- move syspref "PatronRestrictionTypes" to "Accounting > Features" tab
- tweak page title
- tweak tests to apply these changes

Also atomicupdate files have been updated. Issues with delete and tests
is fixed with adding additional schema change file.

To test:
1) Add new restriction type and make it manual.
2) Navigate to patron details page.
3) Add new restriction to patron.
=> Only selectable restriction should be the one
you just created.

Also prove t/db_dependent/RestrictionTypes.t.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
18 files changed:
Koha/RestrictionType.pm
admin/restrictions.pl
installer/data/mysql/atomicupdate/bug_23681_add_PatronRestrictionTypes_syspref.perl [deleted file]
installer/data/mysql/atomicupdate/bug_23681_add_PatronRestrictionTypes_syspref.pl [new file with mode: 0644]
installer/data/mysql/atomicupdate/bug_23681_add_debarment_types.perl [deleted file]
installer/data/mysql/atomicupdate/bug_23681_add_debarment_types.pl [new file with mode: 0644]
installer/data/mysql/atomicupdate/bug_23681_add_manage_patron_restrictions_perm.perl [deleted file]
installer/data/mysql/atomicupdate/bug_23681_add_manage_patron_restrictions_perm.pl [new file with mode: 0644]
installer/data/mysql/en/mandatory/patron_restrictions.sql [deleted file]
installer/data/mysql/en/mandatory/patron_restrictions.txt [deleted file]
installer/data/mysql/en/mandatory/patron_restrictions.yml [new file with mode: 0644]
installer/data/mysql/kohastructure.sql
koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/accounting.pref
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
t/db_dependent/RestrictionTypes.t