]> git.koha-community.org Git - koha.git/commit
Bug 28744: Better handling of undefined to_api_mapping
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 23 Jul 2021 03:39:16 +0000 (00:39 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 8 Sep 2021 20:37:04 +0000 (10:37 -1000)
commit89d2401f63925dfc2a1846a5feee4f36eec04743
treea5ea7b30d139b1b65646ec62c37e9aea62a369d8
parente5c2352aa8b3130d22a462b149dde0639187c247
Bug 28744: Better handling of undefined to_api_mapping

We always had some mapping because of the DB vs. API object definition discrepancies. But bug 25260 revamps the reserves table, and it is a perfect match. It highlights this edge case: if no mapping defined, then and undef from_api_mapping is generated (as opposed to an empty hashref) and this leads to errors in the query translation from the API.

This patch makes a small change so this method always returns an empty
hashref.

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Test fail!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
JD amended patch: remove uneeded commented lines

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 1d6108206d1e4d459d08ee289582f1c017666aaf)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/Object.pm