From b28f439a582a5eafbdfb32b2890d6b069ec2df7c Mon Sep 17 00:00:00 2001 From: Liz Rea Date: Tue, 25 Nov 2014 12:03:50 +1300 Subject: [PATCH] Bug 12123 - [Alternative patch] HTML notices can break the notice viewer Depending on the content of an html notice, it can cause the notice to either not be collapsible, be uncollapsible, or to be permanently collapsed. Test Plan: 1) Set your CHECKOUT notice to the following ( with HTML Message checked ) :

The following items have been checked out:

----
<>
----

Thank you for visiting the <> of HMCPL.

2) Check out some items to a patron 3) View the patrn's notices 4) Note the notice viewer is broken ( message is not collapsed, and con't be collapsed ). 5) Apply this patch 6) Reload the page 7) Note the notice viewer is no longer broken Signed-off-by: Owen Leonard This patch appears to fix the problem with the minimum required change. Signed-off-by: Katrin Fischer Works nicely, no problems found. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi (cherry picked from commit ab2d2d2590fe4adf4adf6015f0ef441da8ad52a3) Signed-off-by: Chris Cormack --- koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt index 31d40bae9d..50c7d0efb0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt @@ -55,9 +55,9 @@ [% QUEUED_MESSAGE.subject %] -

+

[% QUEUED_MESSAGE.content FILTER html_line_break %] -

+
[% IF ( QUEUED_MESSAGE.message_transport_type == 'email' ) %]email -- 2.39.5