From e3858f7f630b15e5e0b77d205d0ab64bbc4b8f22 Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Tue, 10 Dec 2013 18:21:09 +0000 Subject: [PATCH] Bug 11112: (follow-up) add FIXME The caching introduced by the main patch is not ideal as it won't work correctly if a persistance engine is used. However, I have good reason to expect that bug 8089 will be worked on (because I'm going to do it) so that Koha::Cache can be used for this prior to the release of 3.16. Signed-off-by: Galen Charlton (cherry picked from commit aca1f5f6a9c5fb58e62ab060c272eadc287bb167) Signed-off-by: Fridolin SOMERS --- Koha/Calendar.pm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Koha/Calendar.pm b/Koha/Calendar.pm index 293ba88c90..276c7ce391 100644 --- a/Koha/Calendar.pm +++ b/Koha/Calendar.pm @@ -54,6 +54,11 @@ sub _init { } +# FIXME: use of package-level variables for caching the holiday +# lists breaks persistance engines. As of 2013-12-10, the RM +# is allowing this with the expectation that prior to release of +# 3.16, bug 8089 will be fixed and we can switch the caching over +# to Koha::Cache. our ( $exception_holidays, $single_holidays ); sub exception_holidays { my ( $self ) = @_; -- 2.39.5