From d4a54196f5c4fae6935df657a26bb14f4956f5d8 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 5 Oct 2020 09:08:24 +0100 Subject: [PATCH] Bug 26536: Fix incorrectly scoped variable During work on bug 26076 a variable scope mistake was made when reverting the logic to use distinct queries for selected accountlines. This patch restores the script scope of the varaible by removing the superflous 'my' declaration. Test plan 1/ Add a set of manual invoices 2/ Select a subset of those manual invoices to 'Writeoff selected' 3/ Confirm that only those selected invoices have been written off. Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- members/paycollect.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/members/paycollect.pl b/members/paycollect.pl index 471559202e..07b424111f 100755 --- a/members/paycollect.pl +++ b/members/paycollect.pl @@ -150,7 +150,7 @@ if ( $selected_accts ) { accountlines_id => { 'in' => \@acc }, }; - my @selected_accountlines = Koha::Account::Lines->search( + @selected_accountlines = Koha::Account::Lines->search( $search_params, { order_by => 'date' } ); -- 2.39.5