From 52e75e3806ab5ce48bfc20ea9f64e623d8ee40fa Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Fri, 23 Feb 2018 11:41:10 +0100 Subject: [PATCH] Bug 20276: Fix GetCourseItem call to get itemnumber In 17.05.x : In course_reserves/add_items.pl we now get the item via Objects. This line: 66 my $course_item = GetCourseItem( itemnumber => $item->{'itemnumber'} ); Should be: 66 my $course_item = GetCourseItem( itemnumber => $item->itemnumber ); This is corrected since 17.11 by : Bug 18276: Remove GetBiblioFromItemNumber - Course reserves Test plan : 1) Create a course reserve and add items. 2) Correct information must be displayed on the detail page of the course reserve, on staff and OPAC interface. 3) Try to add a non existing barcode, you get the page with a message Signed-off-by: Nick Clemens Signed-off-by: Josef Moravec Signed-off-by: Fridolin Somers --- course_reserves/add_items.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/course_reserves/add_items.pl b/course_reserves/add_items.pl index 0149045749..faa78df82c 100755 --- a/course_reserves/add_items.pl +++ b/course_reserves/add_items.pl @@ -62,8 +62,8 @@ if ( !$item && $action eq 'lookup' ){ $template->param( course => GetCourse($course_id) ); -if ( $action eq 'lookup' ) { - my $course_item = GetCourseItem( itemnumber => $item->{'itemnumber'} ); +if ( $action eq 'lookup' and $item ) { + my $course_item = GetCourseItem( itemnumber => $item->itemnumber ); my $course_reserve = ($course_item) ? GetCourseReserve( -- 2.39.5