From a0cefc86535244b0a603506daf5633a096d5c043 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 4 Dec 2018 19:53:29 +0000 Subject: [PATCH] Bug 21948: Clean up style of item detail page This patch removes some page-specific style from the item detail page in the staff client and adds some markup in order to trigger a more generally-used style. This patch also adds a font-awesome icon to the "Edit item" link on the page. To test, apply the patch and regenerate the staff client CSS. Open a bibliographic record and view the "Items tab." Signed-off-by: Hayley Mapley Signed-off-by: Nick Clemens (cherry picked from commit 32020105e8494ba82a8a505711c5047560c9d304) Signed-off-by: Martin Renvoize --- .../intranet-tmpl/prog/css/src/staff-global.scss | 16 ---------------- .../prog/en/modules/catalogue/moredetail.tt | 12 +++++++++--- 2 files changed, 9 insertions(+), 19 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss index 51016bb0d7..a4c2c025fc 100644 --- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss +++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss @@ -674,22 +674,6 @@ ol { &.bibliodetails { float: left; margin: 0 0 1em 1em; - - li { - border-bottom: 1px solid #E8E8E8; - list-style-type: none; - padding: .1em; - } - - span { - &.label { - border-right: 1px solid #E8E8E8; - float: left; - font-weight: bold; - margin-right: 1em; - width: 12em; - } - } } } diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt index 2e10ef9f46..393d0b90ef 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt @@ -28,6 +28,7 @@

[% title | html %]

[% IF ( subtitle ) %]

[% FOREACH subtitl IN subtitle %] [% subtitl.subfield | html %][% END %]

[% END %] [% IF ( author ) %]

by [% author | html %]

[% END %] +
  1. Biblionumber: [% biblionumber | html %] 
  2. [% UNLESS ( item_level_itypes ) %] @@ -42,6 +43,7 @@
  3. No. of items: [% count | html %] [% IF ( hiddencount ) %]total ([% showncount | html %] shown / [% hiddencount | html %] hidden) Show all items[% END %]
+

[% IF ( ONLY_ONE ) %] @@ -52,9 +54,10 @@

Barcode [% ITEM_DAT.barcode | html %] [% IF ( ITEM_DAT.notforloantext ) %][% ITEM_DAT.notforloantext | html %] [% END %]

Item information [% IF ( CAN_user_editcatalogue_edit_catalogue ) %][% UNLESS ( ITEM_DAT.nomod ) %] [% IF ( CAN_user_editcatalogue_edit_items ) %] - [Edit Item] + Edit item [% END %] [% END %][% END %]

+
  1. Home library: [% Branches.GetName( ITEM_DAT.homebranch ) | html %] 
  2. [% IF ( item_level_itypes ) %] @@ -65,7 +68,7 @@ [% IF ( ITEM_DAT.displaycopy ) %]
  3. Copy number: [% ITEM_DAT.copyvol | html %] 
  4. [% END %] [% IF ( ITEM_DAT.replacementprice ) %]
  5. Replacement price: [% ITEM_DAT.replacementprice | $Price %] 
  6. [% END %] [% IF ITEM_DAT.materials %]
  7. Materials specified: [% ITEM_DAT.materials | html %]
  8. [% END %] -
+

Statuses [% IF ( ITEM_DAT.status_advisory ) %]( [% IF ( ITEM_DAT.notforloantext ) %][% ITEM_DAT.notforloantext | html %] [% END %] [% IF ( ITEM_DAT.itemlost ) %]Lost[% END %] @@ -73,6 +76,7 @@ [% IF ( ITEM_DAT.withdrawn ) %]Withdrawn[% END %] )[% END %]

+
  1. Current location: [% Branches.GetName( ITEM_DAT.holdingbranch ) | html %] 
  2. Checkout status: @@ -190,8 +194,9 @@ [% END %] [% END %] -
+

History

+
    [% IF ITEM_DAT.basketno %] @@ -263,6 +268,7 @@
+
[% END %] -- 2.39.5