]> git.koha-community.org Git - koha.git/commit
Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 22 Dec 2015 10:12:48 +0000 (10:12 +0000)
committerKyle M Hall <kyle@bywatersolutions.com>
Thu, 8 Sep 2016 13:29:22 +0000 (13:29 +0000)
commitcae4b980607be083e5e0fb163c4949c73d6347db
tree81aea7a78f684c06a60daf5603a96b0bd691ba19
parent6239bbd35f31bac5b9c98ab96bad9617c68b5de3
Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType

This unnecessary complicated subroutine returned an arrayref and an
hashref of the patron categories available for the logged in user, for a given
category_type, ordered by categorycode.
This can now be done with the search_limited method.

Test plan:
- Same prerequisite as before
For the following pages, you should not see patron categories limited to other
libraries. They should be ordered as before this patch, by categorycode.
- Add/edit a patron, change his/her patron category value.
- On the 3 following reports:
    reports/bor_issues_top.pl
    reports/borrowers_out.pl
    reports/cat_issues_top.pl
The display for these 3 reports are different than the 2 from the first
patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by
categorycode and the ones limited to other libraries are not displayed
(should certainly be fixed).

Note that the big part of this patch has already been tested before
(update child related: CATCODE_MULTI).

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
26 files changed:
C4/Members.pm
Koha/Patron/Categories.pm
circ/circulation.pl
koha-tmpl/intranet-tmpl/prog/en/modules/members/update-child.tt
koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt
koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_out.tt
koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt
koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_by_borrower_category.tt
members/boraccount.pl
members/mancredit.pl
members/maninvoice.pl
members/member-flags.pl
members/member-password.pl
members/memberentry.pl
members/moremember.pl
members/pay.pl
members/paycollect.pl
members/printfeercpt.pl
members/printinvoice.pl
members/readingrec.pl
members/update-child.pl
reports/bor_issues_top.pl
reports/borrowers_out.pl
reports/cat_issues_top.pl
reports/issues_by_borrower_category.plugin
t/db_dependent/Koha/Patron/Categories.t