From e337bc6cce899af34a96e0276dec020cef8ea2a4 Mon Sep 17 00:00:00 2001 From: Liz Rea Date: Wed, 4 Sep 2019 02:10:21 +0000 Subject: [PATCH] Bug 23537: Overdrive won't show complete results at all times To test: On an overdrive enabled OPAC (tough sell, I know) Do a search for something you know has magazines, the collection I was looking at had "knit" as one Without this patch, the results will show "(many) items found in overdrive collection" but only show a small number of them. With the patch, the number of results should match the number shown/paginated. A site that has this fix applied, is https://tracy.bywatersolutions.com/cgi-bin/koha/opac-overdrive-search.pl?q=knit Before this patch, the number of results was 44, but there were only 8 shown. Now we see all 44 Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize (cherry picked from commit 98e4b5c04a1f89fb168fbc6e7dc40f374cb40ad1) Signed-off-by: Fridolin Somers (cherry picked from commit f05a3767f6c10bc59cedee7588754f7c3e6a0a0c) Signed-off-by: Lucas Gass --- .../opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt index dd9f14f35e..12541efe2f 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt @@ -125,7 +125,7 @@ function search( offset ) { results.push( prod.title ); if ( prod.subtitle ) results.push( ', ', prod.subtitle ); results.push( '' ); - results.push( '

' + _("by") + ' ', prod.primaryCreator.name, '

' ); + if ( prod.primaryCreator ) results.push( '

' + _("by") + ' ', prod.primaryCreator.name, '

' ); results.push( '' + _("Type:") + ' ', prod.mediaType, '' ); if ( prod.starRating ) { -- 2.39.5