]> git.koha-community.org Git - koha.git/commit
Bug 10751: standardize validation of title in staff purchase suggestions form
authorOwen Leonard <oleonard@myacpl.org>
Fri, 21 Feb 2014 14:22:50 +0000 (09:22 -0500)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 21 May 2014 09:19:16 +0000 (11:19 +0200)
commit0092cd702e706a3564bcfd1dcdc1457615c09bb1
treeb56f695e961ca92a7d0bcbb80a44c44d5a3e9905
parentc9057046766fc695385449766d29e011d08de574
Bug 10751: standardize validation of title in staff purchase suggestions form

The form for adding a new purchase suggestion in the staff client
indicates that the title field is required but does nothing to enforce
this rule. This can be handled client-side with HTML5 validation
attributes and Koha's built-in validation plugin. This patch implements
this.

To test, apply the patch and go to Acquisitions ->
Suggestions -> New purchase suggestion. Try submitting the form without
entering a title. Doing so should trigger a validation warning.

Submission of the form with valid data should work correctly. Editing an
existing suggestion should also work correctly.

The patch displays a message 'Required' near the title field.
After submitting a empty title it changes to 'This field is required'
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
The title field is required since commit
d565fb02e9fca2ac9c506e4e7d44fd8b0d66f06a
This one makes it more consistent with formatting. It makes sense.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 59b9078a3f7cf240bd814ee611e8f553d043491e)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Conflicts:
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt