From 5402be60e25ebfe4e0b3b6a8d21283744b14bfd3 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 10 Mar 2023 18:44:21 +0000 Subject: [PATCH] Bug 33198: Don't calculate pickup locations per bib unless placing multiple holds For single bibs we use an ajax select2 dropdown, and we don't use this value To test: 1 - Place some holds on single bibs 2 - Confirm dropdowns for pickup location work as expected 3 - Do the same for multiple bibs selected from search results 4 - Apply patch 5 - Confirm there is no change after the patch Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 63772a9cb25e58ff221540c2a76a7f447bbdeecc) Signed-off-by: Matt Blenkinsop (cherry picked from commit dd7b6e528a18f19ef3a05e36436602416de8bf09) Signed-off-by: Lucas Gass (cherry picked from commit d98074a74730222f127b2ab53e131cc11faec14a) Signed-off-by: Arthur Suzuki --- reserve/request.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reserve/request.pl b/reserve/request.pl index 873c4f79a2..3a36673f95 100755 --- a/reserve/request.pl +++ b/reserve/request.pl @@ -768,7 +768,7 @@ if ( ( $findborrower && $borrowernumber_hold || $findclub && $club_hold ) $template->param( reserveloop => \@reserveloop ); } - if ( $patron ) { + if ( $patron && $multi_hold ) { # Add the valid pickup locations my @pickup_locations = $biblio->pickup_locations({ patron => $patron })->as_list; $biblioloopiter{pickup_locations} = \@pickup_locations; -- 2.39.5