From 299b35c86565a788953a1d7bd69c0e22cf44972e Mon Sep 17 00:00:00 2001
From: Garry Collum <gcollum@gmail.com>
Date: Fri, 17 Jul 2009 20:24:56 -0400
Subject: [PATCH] Bug 2553: Fixes drop-down alphabetization in acquisitions -
 New order and Receive order.

Fixes alphabetization of library dropdown in New Order, and the shelf location, item type, and collection code in the Receive Items pages.  This patch takes care of Joann's original purpose of creating the bug enhancement.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
---
 acqui/neworderempty.pl | 4 ++--
 acqui/orderreceive.pl  | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl
index df23586cc9..ac4a934c4e 100755
--- a/acqui/neworderempty.pl
+++ b/acqui/neworderempty.pl
@@ -145,7 +145,7 @@ for ( my $i = 0 ; $i < $count ; $i++ ) {
 my $itemtypes = GetItemTypes;
 
 my @itemtypesloop;
-foreach my $thisitemtype (sort keys %$itemtypes) {
+foreach my $thisitemtype (sort {$itemtypes->{$a}->{'description'} cmp $itemtypes->{$b}->{'description'}} keys %$itemtypes) {
     push @itemtypesloop, { itemtype => $itemtypes->{$thisitemtype}->{'itemtype'} , desc =>  $itemtypes->{$thisitemtype}->{'description'} } ;
 }
 
@@ -156,7 +156,7 @@ my $onlymine=C4::Context->preference('IndependantBranches') &&
              C4::Context->userenv->{branch};
 my $branches = GetBranches($onlymine);
 my @branchloop;
-foreach my $thisbranch ( sort keys %$branches ) {
+foreach my $thisbranch ( sort {$branches->{$a}->{'branchname'} cmp $branches->{$b}->{'branchname'}} keys %$branches ) {
      my %row = (
         value      => $thisbranch,
         branchname => $branches->{$thisbranch}->{'branchname'},
diff --git a/acqui/orderreceive.pl b/acqui/orderreceive.pl
index c13eda38d8..caabc932e5 100755
--- a/acqui/orderreceive.pl
+++ b/acqui/orderreceive.pl
@@ -104,7 +104,7 @@ if ( $count == 1 ) {
 
     my (@itemtypesloop,@locationloop,@ccodeloop);
     my $itemtypes = GetItemTypes;
-    foreach my $thisitemtype (sort keys %$itemtypes) {
+    foreach my $thisitemtype (sort {$itemtypes->{$a}->{'description'} cmp $itemtypes->{$b}->{'description'}} keys %$itemtypes) {
         push @itemtypesloop, {
                   value => $thisitemtype,
             description => $itemtypes->{$thisitemtype}->{'description'},
@@ -112,14 +112,14 @@ if ( $count == 1 ) {
         };
     }
     my $locs = GetKohaAuthorisedValues( 'items.location' );
-    foreach my $thisloc (sort keys %$locs) {
+    foreach my $thisloc (sort {$locs->{$a} cmp $locs->{$b}} keys %$locs) {
 	    push @locationloop, {
                   value => $thisloc,
             description => $locs->{$thisloc},
         };
     }
     my $ccodes = GetKohaAuthorisedValues( 'items.ccode' );
-	foreach my $thisccode (sort keys %$ccodes) {
+	foreach my $thisccode (sort {$ccodes->{$a} cmp $ccodes->{$b}} keys %$ccodes) {
         push @ccodeloop, {
                   value => $thisccode,
             description => $ccodes->{$thisccode},
-- 
2.39.5