From 4284cbf206279f8974d9e3f2a0b48d0eb5e4fbe7 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 31 Jan 2013 15:56:13 -0500 Subject: [PATCH] Bug 9526 - Patron statistics table is not pretty, needs circ toolbar This patch adds the circ/members toolbar, corrects page title and breadcrumbs, and adds some handling for column names which are coming from the database. The table of statistics can display any items table column specified in the StatisticsFields preference, but we can at least embed the most obvious cases in the template for human readability: item type, collection code, location, home library, and holding library. To test, view the patron statistics page. For a patron with no statistics you should see a message saying so. For a patron with statistics you should see human-friendly labels for the columns referenced above. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Works as described. No errors. Wouldn't be better with centered cell contents? Signed-off-by: Jonathan Druart FIX a typo: -

Statistcs for [% UNLESS ( I ) %][% title %] [% firstname %] [% END %] [% surname %] ([% cardnumber %])

+

Statistics for [% UNLESS ( I ) %][% title %] [% firstname %] [% END %] [% surname %] ([% cardnumber %])

Signed-off-by: Jared Camins-Esakov --- .../prog/en/modules/members/statistics.tt | 31 +++++++++++++++---- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt index 3ff663c1e0..7a9f047be5 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt @@ -3,7 +3,7 @@ [% IF ( unknowuser ) %] Patron does not exist [% ELSE %] - Patron details for [% INCLUDE 'patron-title.inc' %] + Statistics for [% INCLUDE 'patron-title.inc' %] [% END %] @@ -31,7 +31,7 @@
@@ -39,13 +39,30 @@
-
-

Statistics

+ [% INCLUDE 'members-toolbar.inc' %] + +

Statistics for [% UNLESS ( I ) %][% title %] [% firstname %] [% END %] [% surname %] ([% cardnumber %])

+ [% IF ( datas.size ) %] [% FOREACH cn IN column_names %] - + [% END %] @@ -73,7 +90,9 @@
[% cn %] + [% SWITCH cn %] + [% CASE 'itype' %] + Item type + [% CASE 'ccode' %] + Collection code + [% CASE 'location' %] + Shelving location + [% CASE 'homebranch' %] + Home library + [% CASE 'holdingbranch' %] + Holding library + [% CASE %] + [% cn %] + [% END %] + Total checkouts as of yesterday Today's checkouts
-
+ [% ELSE %] +
There are no statistics for this patron.
+ [% END %]
-- 2.39.5