From c0e60a9079c8ffa970676172870eab75ccbcac5d Mon Sep 17 00:00:00 2001 From: Jared Camins-Esakov Date: Mon, 31 Dec 2012 19:45:58 -0500 Subject: [PATCH] Bug 8924: Some modules erroneously skipped by 00-load Several patterns were being skipped unnecessarily in t/00-load.t: * C4::Cache* - no longer exists * C4::Record - no longer requires database * C4::Serials - no longer requires database To test: 1) Unset KOHA_CONF and/or shut down MySQL. 2) Run `prove t/00-load.t` 3) If the test passes, the patch is good. Signed-off-by: Chris Cormack 144 tests passing. Signed-off-by: Jonathan Druart Signed-off-by: Jared Camins-Esakov Conflicts: t/00-load.t Signed-off-by: Chris Cormack Signed-off-by: Liz Rea --- t/00-load.t | 32 +++++++++++++++----------------- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/t/00-load.t b/t/00-load.t index 8f96e22cbb..646f150a94 100644 --- a/t/00-load.t +++ b/t/00-load.t @@ -12,23 +12,21 @@ find({ no_chdir => 1, wanted => sub { my $m = $_; - return unless $m =~ s/[.]pm$//; - $m =~ s{^.*/C4/}{C4/}; - $m =~ s{/}{::}g; - return if $m =~ /Auth_with_ldap/; # Dont test this, it will fail on use - return if $m =~ /Cache/; # Cache modules are a WIP, add the tests back when we are using them more - return if $m =~ /SIP/; # SIP modules will not load clean - return if $m =~ /C4::VirtualShelves$/; # Requires a DB - return if $m =~ /C4::Auth$/; # DB - return if $m =~ /C4::Tags$/; # DB - return if $m =~ /C4::Service/; # DB - return if $m =~ /C4::Auth_with_cas/; # DB - return if $m =~ /C4::BackgroundJob/; # DB - return if $m =~ /C4::UploadedFile/; # DB - return if $m =~ /C4::Record/; # DB - return if $m =~ /C4::Reports::Guided/; # DB - return if $m =~ /C4::Serials/; # DB - return if $m =~ /C4::VirtualShelves::Page/; # DB + return unless $m =~ s/[.]pm$//; + $m =~ s{^.*/C4/}{C4/}; + $m =~ s{/}{::}g; + return if $m =~ /Auth_with_ldap/; # Dont test this, it will fail on use + return if $m =~ /SIP/; # SIP modules will not load clean + return if $m =~ /C4::VirtualShelves$/; # Requires a DB + return if $m =~ /C4::Auth$/; # DB + return if $m =~ /C4::Tags$/; # DB + return if $m =~ /C4::Service/; # DB + return if $m =~ /C4::Auth_with_cas/; # DB + return if $m =~ /C4::BackgroundJob/; # DB + return if $m =~ /C4::UploadedFile/; # DB + return if $m =~ /C4::Reports::Guided/; # DB + return if $m =~ /C4::VirtualShelves::Page/; # DB + return if $m =~ /C4::Members::Statistics/; # DB use_ok($m) || BAIL_OUT("***** PROBLEMS LOADING FILE '$m'"); }, }, $lib); -- 2.39.5