]> git.koha-community.org Git - koha.git/commit
Bug 6503 - Variable $sth is declared 3 times (with keyword "my") in "makepayment...
authorRicardo Dias Marques <koha@ricmarques.net>
Tue, 14 Jun 2011 17:24:29 +0000 (18:24 +0100)
committerChris Nighswonger <chris.nighswonger@gmail.com>
Tue, 26 Jul 2011 02:06:35 +0000 (22:06 -0400)
commita5d777bd3f54b8d7adc3f67e4813da1ff7c2f65e
tree8612d1b558518968cc7f3aafb8fdf058be25114d
parentd397e16eb37307db863e08ced35969ed7c1c699e
Bug 6503 - Variable $sth is declared 3 times (with keyword "my") in "makepayment" sub of "Accounts.pm"

In the code available today (14-Jun-2011), in Koha git's "master" branch,
the file "Accounts.pm" (in the "C4" directory) has the variable "$sth"
declared 3 times in the "makepayment" sub. This causes the following
warnings to appear when running "make test" in Koha installation, for
several tests:
t/Heading.t ......................... "my" variable $sth masks earlier declaration
in same scope at kohaclone/blib/PERL_MODULE_DIR/C4/Accounts.pm line 172.
"my" variable $sth masks earlier declaration in same scope at
kohaclone/blib/PERL_MODULE_DIR/C4/Accounts.pm line 188.
[...]
t/ILSDI_Services.t .................. "my" variable $sth masks earlier declaration
in same scope at kohaclone/blib/PERL_MODULE_DIR/C4/Accounts.pm line 172.
"my" variable $sth masks earlier declaration in same scope
at kohaclone/blib/PERL_MODULE_DIR/C4/Accounts.pm line 188.
[...etc...]

Therefore, I'm removing the "my" keyword from the declarations of "$sth"
in lines 172 and 188 of "Accounts.pm".

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 71d22ab82758f159c9e8b71f7801ef6b43f38a90)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
C4/Accounts.pm