From 0ba79c681b0f29b6603191e37ffa71e20b0f7527 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Mon, 30 Mar 2020 15:16:36 +0000 Subject: [PATCH] Bug 23601: Prevent default for auxclick The issue appears to be that the default action is not prevented for middle click because it registers an 'auxclick' event as opposed to a 'click' event To test: 1 - Perform a search in staff client 2 - Shift-click and hold on a result 3 - Note a new tab opens 4 - Release the click, no change 5 - Middle click and hold on a result 6 - New tab opens 7 - Release, a second new tab opens 8 - Apply patch 9 - Reload page 10 - Middle click and hold 11 - New tab opens 12 - Release 13 - No new tab Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 9f89eabcd5befe34d4b3ad75fb8b128f4de131f3) Signed-off-by: Lucas Gass --- koha-tmpl/intranet-tmpl/js/browser.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/js/browser.js b/koha-tmpl/intranet-tmpl/js/browser.js index 3b9ca87cbb..ec27afa696 100644 --- a/koha-tmpl/intranet-tmpl/js/browser.js +++ b/koha-tmpl/intranet-tmpl/js/browser.js @@ -65,7 +65,7 @@ KOHA.browser = function (searchid, biblionumber) { sessionStorage.setItem('searches', JSON.stringify(searches)); $(document).ready(function () { //FIXME It's not a good idea to modify the click events - $('#searchresults table tr a[href*="/detail.pl"]').on('click', function (ev) { + $('#searchresults table tr a[href*="/detail.pl"]').on('click auxclick', function (ev) { ev.preventDefault(); }); $('#searchresults table tr a[href*="/detail.pl"]').on('mousedown', function (ev) { -- 2.39.5