From 71384ce51b344babf3ca698ad8529be4caadf172 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 7 Mar 2022 11:30:35 +0100 Subject: [PATCH] Bug 30234: Fix local cover image display for other holdings Bug 26145 added the ability to add local cover images to items. If SeparateHoldings is set, items from other libraries are displayed in a separate tab, and not considered as visible. We have a JS test to assume that images not shown are not present, this only apply for the images for the bibliographic record, as they can come from different sources. Test plan: Turn on LocalCoverImages and SeparateHoldings Create a record with different items coming from different libraries Attach images to items and to the biblio Notice that with this patch you can see the images from the "Other holdings" tab Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 54734f68f21a2d4d248e339d144b67e071317236) Signed-off-by: Lucas Gass (cherry picked from commit 73604cdbcc1e777d39c85fc9337246d6b4821b28) Signed-off-by: Arthur Suzuki (cherry picked from commit 2ef2b2d3b26626a5d61dd60b1ddac1ed448c6c51) Signed-off-by: Victor Grousset/tuxayo --- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index 03c55e144e..420cd0ac93 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -1108,7 +1108,8 @@ Note that permanent location is a code, and location may be an authval. }); } - if( $(coverSlide).find(".cover-image:visible").length < 1 ){ + if( $(coverSlide).attr('id') == 'biblio-cover-slider' // Hide if not visible, but only for the biblio images. Images for items are only local cover images + && $(coverSlide).find(".cover-image:visible").length < 1 ){ $(coverSlide).remove(); } else { $(coverSlide).addClass("cover-slides"); -- 2.39.5