From cd533cb16a6844181cae5befbef61af51651ddef Mon Sep 17 00:00:00 2001 From: Shi Yao Wang Date: Fri, 23 Feb 2024 15:01:43 -0500 Subject: [PATCH] Bug 35911: Make archived suggestions not show in patron's account Remove archived suggestions in patron's account page Test plan: 1. Go to a patron's account in the staff interface 2. Go to the Suggestions tab 3. Click New purchase suggestion and create a suggestion 4. In another browser tab, go to Acquisitions > Suggestions 5. Click the small arrow next to the edit button to the right of the suggestion, and choose Archive (alternatively, check the suggestion's box and click Archive selected) --> Suggestion disappears from the suggestions management page (OK) 6. Go back to the tab with the patron's account and refresh --> Suggestion is still visible 7. Apply the patch 8. Redo step 6 and notice the suggestion is not visible anymore 9. Redo step 4 and 5 but this time, unarchiving the suggestion 10. Redo step 6 and notice the suggestion is back Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer (cherry picked from commit ac71adbd23e2d3a6c599ac963b042576dca635f3) Signed-off-by: Fridolin Somers (cherry picked from commit d35481b1abb0f9fe30acefd14070f74d1265c50b) Signed-off-by: Lucas Gass --- members/purchase-suggestions.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/members/purchase-suggestions.pl b/members/purchase-suggestions.pl index 1739e841ae..0268582bef 100755 --- a/members/purchase-suggestions.pl +++ b/members/purchase-suggestions.pl @@ -49,7 +49,7 @@ $template->param( ); my $suggestions = [ - Koha::Suggestions->search_limited( { suggestedby => $borrowernumber }, + Koha::Suggestions->search_limited( { suggestedby => $borrowernumber, archived => 0 }, { prefetch => 'managedby' } )->as_list ]; -- 2.39.5