]> git.koha-community.org Git - koha.git/log
koha.git
12 years agoBug 7760: Add unique ids and a module class to all acquisitions pages
Katrin Fischer [Tue, 20 Mar 2012 15:41:17 +0000 (16:41 +0100)]
Bug 7760: Add unique ids and a module class to all acquisitions pages

This is the first patch for bug 7760 and touches all pages in acquisitions.
This adds a unique id "acq_<filename>" and a class "acq" to the body tag of
each page in acquisitions.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoSIGNED-OFF Bug 7590 Cataloging authorities search result page is broken
Frédéric Demians [Fri, 24 Feb 2012 07:50:16 +0000 (08:50 +0100)]
SIGNED-OFF Bug 7590 Cataloging authorities search result page is broken

This bug occurs on UNIMARC DB with authorities linked together with TS/TG
relations. To reproduce it:

- Add a new biblio record
- On 610 field, click on the tag editor button to search an authority
- In the Authority search window, enter a large search
- On the result page, for authorities having relations with other terms, in the
  Get it! column, you get a mess of TS/TG relations and not more Choose link.

Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 5841: Routing slip not displaying publication date
Katrin Fischer [Tue, 21 Feb 2012 06:19:54 +0000 (07:19 +0100)]
Bug 5841: Routing slip not displaying publication date

To test:
Compare output of the 2 different links for  printing routing lists.

1) Links in the table of issues on the serial collection page
2) Link following the steps from editing and saving a routing list

Both previews should show the date now.

Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 6125: repairs dateaccessioned plugin
Adrien Saurat [Tue, 20 Mar 2012 12:56:56 +0000 (13:56 +0100)]
Bug 6125: repairs dateaccessioned plugin

1/ It now works with neworderempty.pl
2/ The set_to_today function was moved from
additem.tt to dateaccessioned.pl (so it's
available to all pages using the plugin)

Signed-off-by: Julien Sicot <julien.sicot@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 5482 [Follow up] Translation problem in guided reports - Item field names
Owen Leonard [Wed, 21 Mar 2012 14:01:49 +0000 (15:01 +0100)]
Bug 5482 [Follow up] Translation problem in guided reports - Item field names

Making some additional corrections.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 5482: Update colums.def file
Katrin Fischer [Tue, 20 Mar 2012 14:39:46 +0000 (15:39 +0100)]
Bug 5482: Update colums.def file

Updates the borrowers and items table descriptions using the
descriptions from the interface and the MARC21 default framework.
Biblio and biblioitems still need some work.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 5482 - Translation problem in guided reports - Item field names
Owen Leonard [Tue, 20 Mar 2012 11:10:52 +0000 (12:10 +0100)]
Bug 5482 - Translation problem in guided reports - Item field names

This very minor correction adds display of the column name even
if the field description exists in the columns .def file.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Changes the display to show description / table.column.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 5180: FIX autocomplete on overdues report
Jonathan Druart [Wed, 14 Mar 2012 13:34:27 +0000 (14:34 +0100)]
Bug 5180: FIX autocomplete on overdues report

- Switch off the CircAutocompl syspref
- Set a (one or more) patron attr type searchable
- go on the overdues page
Firebug crash and a layout problem appears on the left.

Firebug error is "YAHOO.widget.DS_XHR is not a constructor"

retry with this patch.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7738: "Display more constraints' in subfield configuraiton is not properly transl...
Katrin Fischer [Mon, 19 Mar 2012 15:05:55 +0000 (16:05 +0100)]
Bug 7738: "Display more constraints' in subfield configuraiton is not properly translatable

The Javascript toggling the link description was checking for the english
link text. This would not work for translated templates.

Tested: Apply patch, then translate update and translate install.
Text changes as appropriate (with manually inserted translation in .po file)

Signed-off-by: mveron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7746: "No Public Lists." not translatable.
Katrin Fischer [Mon, 19 Mar 2012 16:06:23 +0000 (17:06 +0100)]
Bug 7746: "No Public Lists." not translatable.

I applied the patch and did a translate update / translate install.
No public lists is now surrounded by P-tags as expected.

Signed-off-by: mveron <veron@veron.ch>
Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
QA Comment:  fixed small typo ('pists' instead of 'lists')

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7753: serials-home displays library name instead of code
Adrien Saurat [Tue, 20 Mar 2012 13:42:21 +0000 (14:42 +0100)]
Bug 7753: serials-home displays library name instead of code

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7700: Cart's more details view shows identity numbers
Katrin Fischer [Sun, 11 Mar 2012 17:47:18 +0000 (18:47 +0100)]
Bug 7700: Cart's more details view shows identity numbers

We already remove $9 with Koha's authority number from output
of GetMarcSubjects and GetMarcAuthors.
Patch additionally removes $0 subfields with identity numbers.

Patch also effects detail pages with normal (non-XSLT) views.

Revised to always remove $0 subfields, they are not used in UNIMARC.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7581: Singlebranchmode was always 0 causing the branch to be null and the reserva...
Maxime Pelletier [Wed, 22 Feb 2012 17:00:28 +0000 (12:00 -0500)]
Bug 7581: Singlebranchmode was always 0 causing the branch to be null and the reservations in the OPAC not to work in singlebranchmode.

Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>
http://bugs.koha-community.org/show_bug.cgi?id=7581
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7597 - Part 5 - Remove my from $branch, which was masking previous declaration
Kyle M Hall [Thu, 8 Mar 2012 19:35:08 +0000 (14:35 -0500)]
Bug 7597 - Part 5 - Remove my from $branch, which was masking previous declaration

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7597 - Part 4 - Change C4::Acounts::WriteOff to WriteOffFee
Kyle M Hall [Mon, 5 Mar 2012 20:29:44 +0000 (15:29 -0500)]
Bug 7597 - Part 4 - Change C4::Acounts::WriteOff to WriteOffFee

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7597 - Part 3 - fines not recording the right info in the stats table
Kyle M Hall [Tue, 28 Feb 2012 14:34:59 +0000 (09:34 -0500)]
Bug 7597 - Part 3 - fines not recording the right info in the stats table

This commit fixes writeoff_all to write off only the amount outstanding
for each fine being written off, rather than the original amount owed.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Tested all three patches together and was able to write off single
and multiple fines and the data was correct in the stats table.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7597 - Part 2 - move sub writeoff to C4::Accounts
Kyle M Hall [Tue, 28 Feb 2012 14:17:04 +0000 (09:17 -0500)]
Bug 7597 - Part 2 - move sub writeoff to C4::Accounts

Currently, the subroutine writeoff lives in pay.pl, which
is a violation of the Koha coding guidelines, as it writes
to the database. This commit restructures and moves writeoff
to C4::Accounts::WriteOff(), and modifies pay.pl to use it.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Tested all three patches together and was able to write off single
and multiple fines and the data was correct in the stats table.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7597 - Part 1 - fines not recording the right info in the stats table
Kyle M Hall [Tue, 28 Feb 2012 13:47:43 +0000 (08:47 -0500)]
Bug 7597 - Part 1 - fines not recording the right info in the stats table

Koha was writing off the value of accountlines.amount rather
than the value of accountlines.ammountoutstanding.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Tested all three patches together and was able to write off single
and multiple fines and the data was correct in the stats table.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7092 follow-up: Update DBRev
Jared Camins-Esakov [Thu, 3 May 2012 23:10:56 +0000 (19:10 -0400)]
Bug 7092 follow-up: Update DBRev

Version 3.06.04.003.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7092 - Complete-subfield searches TraceCompleteSubfields syspref not working...
Magnus Enger [Mon, 5 Mar 2012 12:36:43 +0000 (13:36 +0100)]
Bug 7092 - Complete-subfield searches TraceCompleteSubfields syspref not working correctly

This patch adds a syspref UseICU for toggling between using "" and {} for
quoting in subject tracings. With normal Zebra indexing, "" must be used. With
ICU Zebra indexing, {} must be used.

This syspref interacts with TraceCompleteSubfields and TraceSubjectSubdivisions.

To test:

- marcflavour = MARC21
- make sure you have a record with a "complex subject", like
  "Internet -- Law and legislation"

Toggle UseICU, TraceCompleteSubfields, and TraceSubjectSubdivisions and check
that you get the expected results for the clickable links in the OPAC detail
view:

TraceCompleteSubfields   = Don't force
TraceSubjectSubdivisions = Don't include
UseICU                   = Not using
  opac-search.pl?q=su:"Internet"
UseICU                   = Using
  opac-search.pl?q=su:{Internet}

TraceCompleteSubfields   = Force
TraceSubjectSubdivisions = Don't include
UseICU                   = Not using
  opac-search.pl?q=su,complete-subfield:"Internet"
UseICU                   = Using
  opac-search.pl?q=su,complete-subfield:{Internet}

TraceCompleteSubfields   = Don't force
TraceSubjectSubdivisions = Include
UsingICU                 = Not using
  opac-search.pl?q=(su:"Internet") and (su:"Law and legislation.")
UsingICU                 = Using
  opac-search.pl?q=(su:{Internet}) and (su:{Law and legislation.})

TraceCompleteSubfields   = Force
TraceSubjectSubdivisions = Include
UseICU                   = Not using
  opac-search.pl?q=(su,complete-subfield:"Internet") and (su,complete-subfield:"Law and legislation.")
UseICU                   = Using
  opac-search.pl?q=(su,complete-subfield:{Internet}) and (su,complete-subfield:{Law and legislation.})

Check that clicking on the generated links gives the expected search results,
but with normal and ICU indexing. (I have actually not tested this with ICU, so
doing that before signing off is crucial.)

UPDATE 2012-03-16:

Changed the name of the syspref from TracingQuotes to UseICU after a suggestion
from Paul P., to make it more generally useful.

I have used "Using/Not using" instead of "Use/Don't use" in the description of
the syspref, to reflect the fact that this syspref will not change how Zebra
does its indexing - it's just a way of telling Koha how the indexing is
actually done.

I have also set UseICU = 1 in updatedatabase.pl, since that will preserve the
current behaviour of Koha, but UseICU = 0 in sysprefs.sql, since most new
installations will not have ICU activated.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7734: NO_LIBRARY_SET should be translatable
Katrin Fischer [Mon, 19 Mar 2012 13:38:30 +0000 (14:38 +0100)]
Bug 7734: NO_LIBRARY_SET should be translatable

To test:
- Make sure you are logged into Koha as 'root' user - not superlibrarian
- Before the patch the label will show 'NO_LIBRARY_SET', after applying
  the patch it will be 'NO LIBRARY SET' without underscores.
- Verify correct description is shown after selecting a library.

Signed-off-by: mveron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7749: Not all OKs on the start page are translatable
Katrin Fischer [Mon, 19 Mar 2012 17:10:10 +0000 (18:10 +0100)]
Bug 7749: Not all OKs on the start page are translatable

I don't really understand, why the " OK " would not get picked up by
the translation script, but removing the spaces made it work.

To test:
Verify that all OK buttons on the start page are translatable. The one
resisting translation was "Search catalog:"

Signed-off-by: mveron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 5657: Changes made to sub merge to eliminate errors occuring when updating bibio...
Janusz Kaczmarek [Tue, 25 Jan 2011 17:10:00 +0000 (18:10 +0100)]
Bug 5657: Changes made to sub merge to eliminate errors occuring when updating bibio records in batch (after updating multiple authority records)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agowelcome gaetan, you're 179th !
Paul Poulain [Tue, 20 Mar 2012 14:58:50 +0000 (15:58 +0100)]
welcome gaetan, you're 179th !

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7724: Skip Linker test if Zebra isn't set up
Jared Camins-Esakov [Fri, 16 Mar 2012 11:38:24 +0000 (07:38 -0400)]
Bug 7724: Skip Linker test if Zebra isn't set up

One of the tests in t/db_dependent/Linker_FirstMatch.t ony works if Zebra is
running and authorities have been indexed. This was causing Jenkins agitas.
The test should be skipped if Zebra isn't running or authorities have not been
indexed at the time the test is run.

Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agobug_7140: Added item description to complement icon to search result and biblio detai...
Srdjan Jankovic [Fri, 27 Jan 2012 03:59:27 +0000 (16:59 +1300)]
bug_7140: Added item description to complement icon to search result and biblio detail pages

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
This seems like a very big improvement, especially for people using screen
readers. I agree that the change to C4::Search is required.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 4976 - Status of item returned with process_koc.pl is empty in Intranet
Kyle M Hall [Fri, 9 Mar 2012 21:34:47 +0000 (16:34 -0500)]
Bug 4976 - Status of item returned with process_koc.pl is empty in Intranet

Fix to ensure items returned through a processed koc file have
items.onloan and items.datelastseen set corrrectly.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Uploaded a file with checked in and checked out items. all info
shows properly.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7670 - make required fields red
Owen Leonard [Thu, 8 Mar 2012 13:53:45 +0000 (08:53 -0500)]
Bug 7670 - make required fields red

Adding "required" style and "Required" note to additem fields,
consistent with the way required fields are displayed
on the add patron form.

This patch also corrects an error in the client-side validation
script which misidentified which fields were required. Leaving
a required field empty should result in an alert and the missing
field being highlighted in yellow.

To test, open the add item form on a record which uses
a framework in which one or more item fields are required.
Required fields should be labeled in red and appended with a
"Required" note.

Submit the form while some required fields are empty. You should
see a javascript alert. The empty mandatory fields should have
a yellow background.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Works - passes tests.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7656 - "undefined" pop-up message when putting hold on reference item
Kyle M Hall [Tue, 6 Mar 2012 19:08:04 +0000 (14:08 -0500)]
Bug 7656 - "undefined" pop-up message when putting hold on reference item

This is a single line fix. Initializing the msg var to an empty
string solves the problem.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agowelcome David Cook, you're 178th
Paul Poulain [Fri, 16 Mar 2012 10:54:13 +0000 (11:54 +0100)]
welcome David Cook, you're 178th

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7618 Escape HTML special characters for SQL displayed above results in Report...
David [Mon, 12 Mar 2012 23:17:32 +0000 (10:17 +1100)]
Bug 7618 Escape HTML special characters for SQL displayed above results in Report module

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years ago7368 Typo in cart_to_shelf
Marcel de Rooy [Mon, 12 Mar 2012 11:33:07 +0000 (12:33 +0100)]
7368 Typo in cart_to_shelf

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7644 - Invalid markup in staff client language chooser
Owen Leonard [Mon, 5 Mar 2012 19:47:51 +0000 (14:47 -0500)]
Bug 7644 - Invalid markup in staff client language chooser

This patch removes invalid markup from the language chooser
in the intranet. It also copies the markup and style of
the staff client include to the OPAC so the two are
more consistent. I hope that will make future changes
and debugging a little easier.

I believe this patch also fixes Bug 7366, "Language chooser
display problems."

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch fixes bug 7366, but there is still a difference between staff
and OPAC.
Installed languages: en, en-NZ, de-DE, fr-FR
Activated langauges: en, en-NZ, fr-FR
OPC shows English, staff shows en-NZ as label for the list.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 5749 Fix borrower address display in intranet
Stéphane Delaune [Tue, 6 Mar 2012 15:20:01 +0000 (16:20 +0100)]
Bug 5749 Fix borrower address display in intranet

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7699: Restricted until datepicker broken
Jared Camins-Esakov [Sun, 11 Mar 2012 17:19:00 +0000 (13:19 -0400)]
Bug 7699: Restricted until datepicker broken

To test:
1. Edit a patron, and try to use the datepicker to set the date the patron is
   restricted until.
2. Note that the datepicker does not come up.
3. Apply patch.
4. Repeat step 1.
5. Note that the datepicker does come up.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7609: Improving links to find analytics and volumes when using UseControlnumber...
Katrin Fischer [Sun, 26 Feb 2012 21:25:41 +0000 (22:25 +0100)]
Bug 7609: Improving links to find analytics and volumes when using UseControlnumber (MARC21)

To test:
- switch on UseControlnumber
- add a serial record with 001
  - ldr pos 19 = a or
  - 008 (continuing resource), pos 21 = m
- add 2 analytics with with $w subfields containing the 001 of the serial
  - one with ldr pos 7 = a
  - one with ldr pos 7 = b
- add 1-2 monographical records linked to the serial
  - 8xx $w subfield containing the 001 of the serial
  - 490

The serial should show 2 links (in both OPAC and Intranet):
'Show volumes' should only bring up the monographical records.
'Show analytics' should only find the analytical records.

Without the patch both links would find all linked records, no difference
between both links.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 3216: UNIMARC author facets
Frédéric Demians [Fri, 2 Dec 2011 06:56:27 +0000 (07:56 +0100)]
Bug 3216: UNIMARC author facets

Add 700$b to UNIMARC author facets.

Other facets subfields could be added now. For example, other subjects
subfields.

Following patches are required to handle better MARC21 subfields and choose
other subfields to deal with UNIMARC format.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Tested under both MARC21 and UNIMARC. Does not cause any regressions with
MARC21, and offers the possibility for better faceting there in the future.
Works as advertised with UNIMARC.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7665 - Bibs with no ISBN's show broken images for covers when using Syndetics...
Liz Rea [Wed, 7 Mar 2012 19:29:58 +0000 (13:29 -0600)]
Bug 7665 - Bibs with no ISBN's show broken images for covers when using Syndetics cover images

Patch fixes problem for syndetics + bibs with no ISBN. Also adds "no image found" capability to Syndetics results.

To test (first, contact me and I will let you use my syndetics credentials *for testing this bug only*):
* replicate bug - have a bib with an ISBN, and one without. The one with the ISBN should show a cover, the one without will show a broken image.
* apply patch
* search for the same bib - you should now see "no image available" for the one with no ISBN, and a cover image for your bib with an ISBN.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
QA Comment:  normalized spacing

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7636 - error when trying to email cart when opacuserlogin set to don't allow
Owen Leonard [Thu, 1 Mar 2012 20:06:25 +0000 (15:06 -0500)]
Bug 7636 - error when trying to email cart when opacuserlogin set to don't allow

This patch hides the "send cart" link if the opacuserlogin
preference is set to disallow. Other similar changes included:

- hide the "send list" link
- hide the "your lists" tab
- hide the "log in to create your own lists" link
- hide the "recent comments" link

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Tested with opacuserlogin set to both "Allow" and "Don't allow." With
opacuserlogin set to "Allow," the links showed up, and with opacuserlogin
set to "Don't allow," the links did not.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7645 - System preferences editor save button obscured by language chooser
Owen Leonard [Mon, 5 Mar 2012 17:38:00 +0000 (12:38 -0500)]
Bug 7645 - System preferences editor save button obscured by language chooser

This patch amends the preferences page's CSS file to add
bottom padding to the page container. This gives the bottom-
most submit button some breathing room.

Markup correction: Adding "row" and "col" attributes to
<textareas> to quiet validation errors. This doesn't
affect output at all (dimensions are specified in CSS).

To test, open the system preferences page to a tab like OPAC
which contains many preferences. At the bottom of the page
the last submit button should have about a line's worth of
white space below it.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7631 - Self checkout renewal fails because of reference to non-existent subroutin...
Owen Leonard [Thu, 1 Mar 2012 15:00:14 +0000 (10:00 -0500)]
Bug 7631 - Self checkout renewal fails because of reference to non-existent subroutine in sco-main.pl

Changing "CanBookBeIssuedCheckout" to "CanBookBeIssued"

To test, try to renew an item which has no renewals left. Before the patch
you'll get an error:

Undefined subroutine &main::CanBookBeIssuedCheckout called at /opac/sco/sco-main.pl line 135.

After the patch you'll get the correct message about having no renewals left.
Other tests: checking out a barcode which doesn't exist, checking out an
item which is on hold for another patron.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 6488: Display OPAC search result count conditional to OpacHiddenItems syspref
Srdjan Jankovic [Wed, 7 Mar 2012 03:53:09 +0000 (16:53 +1300)]
Bug 6488: Display OPAC search result count conditional to OpacHiddenItems syspref

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Works as advertised. Amended this patch for a small spelling issue: supress->suppress. Could not suppress it ;)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7629 - Update sco.css to include CSS Gradients and prevent error upon missing...
Owen Leonard [Thu, 1 Mar 2012 14:40:01 +0000 (09:40 -0500)]
Bug 7629 - Update sco.css to include CSS Gradients and prevent error upon missing background image file

Copying CSS gradients for input buttons and dialogs from opac.css. Also copied missing
CSS for language-picker footer. Markup corrected in a couple of places in order
for the right style to be applied.

To test corrections to dialog CSS, enter an invalid patron barcode.
Multiple languages will have to be enabled in order to see the footer
correction working.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Dialog CSS looks correct, footer also looks correct with multi languages.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7271 - change sort in items.pm to sort by home library instead of holding branch
Liz Rea [Mon, 28 Nov 2011 17:39:33 +0000 (11:39 -0600)]
Bug 7271 - change sort in items.pm to sort by home library instead of holding branch

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7493 follow-up: Update DBRev
Jared Camins-Esakov [Thu, 3 May 2012 22:37:52 +0000 (18:37 -0400)]
Bug 7493 follow-up: Update DBRev

Version 3.06.04.002.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7493 [REVISED] Deleting a record with comments breaks "Recent Comments"
Owen Leonard [Mon, 6 Feb 2012 14:05:18 +0000 (09:05 -0500)]
Bug 7493 [REVISED] Deleting a record with comments breaks "Recent Comments"

Adding foreign key constraint on biblio and borrowers:

- delete reviews when bibliographic records are deleted
- set set reviews.borrowernumber to NULL when patron records are deleted.

Before these constraints are set the database update script will
clean up existing instances of these problems by deleting reviews of
deleted biblios and setting to NULL reviews.borrowernumber for deleted
patrons.

In comments moderation, the list of comments will indicate "(deleted patron")
if the review was submitted by a patron who has since been deleted.

In the OPAC display of comments will omit the patron name altogether
if the patron has since been deleted.

To test:

1. CONFIRM THAT THE DATABASE UPDATE RUNS CORRECTLY

Before applying the patch:

 - delete the record for a title which has a review
 - delete a patron who has submitted a review (on a different title).

Viewing /cgi-bin/koha/opac-showreviews.pl should result in an error.

Apply the patch and make sure the database update runs. Viewing
the recent comments page in the OPAC should no longer result in an
error. The title with the comment from a deleted patron should
show no patron name on these pages:

 - Recent comments (opac-showreviews.pl)
 - Recent comments RSS (opac-showreviews.pl?format=rss)
 - Detail page (opac-detail.pl)

Comments from other patrons should show correctly.

2. CONFIRM THAT NEW DELETIONS PERFORM CORRECTLY

After applying the patch:

 - delete the record for a title which has a review
 - delete a patron who has submitted a review (on a different title).

Viewing /cgi-bin/koha/opac-showreviews.pl should NOT result in an error.
The review of the title which you deleted should no longer appear in the
list of recent comments.

The title with the comment from a deleted patron should
show no patron name on these pages:

 - Recent comments (opac-showreviews.pl)
 - Recent comments RSS (opac-showreviews.pl?format=rss)
 - Detail page (opac-detail.pl)

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7284 follow-up: Update DBRev
Jared Camins-Esakov [Thu, 3 May 2012 22:36:55 +0000 (18:36 -0400)]
Bug 7284 follow-up: Update DBRev

Version 3.06.04.001.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agobug 7284: fix package build problem, move BEGIN into new
MJ Ray [Thu, 29 Mar 2012 17:35:04 +0000 (18:35 +0100)]
bug 7284: fix package build problem, move BEGIN into new

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7284: Authority matching improvements
Jared Camins-Esakov [Sat, 31 Dec 2011 17:17:41 +0000 (12:17 -0500)]
Bug 7284: Authority matching improvements

Squashed patch incorporating all previous patches (there is no functional
change compared to the previous version of this patch, this patch merely
squashes the original patch and follow-up, and rebases on latest master).

=== TL;DR VERSION ===
*** Installation ***
1. Run installer/data/mysql/atomicupdate/bug_7284_authority_linking_pt1
and installer/data/mysql/atomicupdate/bug_7284_authority_linking_pt2
2. Make sure you copy the following files from kohaclone to koha-dev:
etc/zeradb/authorities/etc/bib1.att,
etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml,
etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl,
etc/zebradb/marc_defs/marc21/authorities/koha-indexdefs-to-zebra.xsl, and
etc/zebradb/marc_defs/unimarc/authorities/record.abs
3. Run misc/migration_tools/rebuild_zebra.pl -a -r

*** New sysprefs ***
* AutoCreateAuthorities
* CatalogModuleRelink
* LinkerModule
* LinkerOptions
* LinkerRelink
* LinkerKeepStale

*** Important notes ***
You must have rebuild_zebra processing the zebraqueue for bibs when testing this
patch.

=== DESCRIPTION ===

*** Cataloging module ***
* Added an additional box to the authority finder plugin for "Heading match,"
  which consults not just the main entry but also See-from and See-also-from
  headings.

* With this patch, the automatic authority linking will actually work properly
  in the cataloging module. As Owen pointed out while testing the patch,
  though, longtime users of Koha will not be expecting that. In keeping with
  the principles of least surprise and maximum configurability, a new syspref,
  CatalogModuleRelink makes it possible to disable authority relinking in the
  cataloging module only (i.e. leaving it enabled for future runs of
  link_bibs_to_authorities.pl).  Note that though the default behavior matches
  the current behavior of Koha, it does not match the intended behavior.
  Libraries that want the intended behavior rather than the current behavior
  will need to adjust the CatalogModuleRelink syspref.

*** misc/link_bibs_to_authorities.pl ***
Added the following options to the misc/link_bibs_to_authorities.pl script:
--auth-limit        Only process those headings that match the authorities
                    matching the user-specified WHERE clause.
--bib-limit         Only process those bib records that match the
                    user-specified WHERE clause.
--commit            Commit the results to the database after every N records
                    are processed.
--link-report       Display a report of all the headings that were processed.

Converted misc/link_bibs_to_authorities.pl to use POD.

Added a detailed report of headings that linked, did not link, and linked
in a "fuzzy" fashion (the exact semantics of fuzzy are up to the individual
linker modules) during the run.

*** C4::Linker ***
Implemented new C4::Linker functionality to make it possible to easily add
custom authority linker algorithms. Currently available linker options are:
* Default: retains the current behavior of only creating links when there is
  an exact match to one and only one authority record; if the 'broader_headings'
  option is enabled, it will try to link to headings to authority records for
  broader headings by removing subfields from the end of the heading (NOTE:
  test the results before enabling broader_headings in a production system
  because its usefulness is very much dependent on individual sites' authority
  files)
* First Match: based on Default, creates a link to the *first* authority
  record that matches a given heading, even if there is more than one
  authority record that matches
* Last Match: based on Default, creates a link to the *last* authority
  record that matches a given heading, even if there is more than one record
  that matches

The API for linker modules is very simple. All modules should implement the
following two functions:
<get_link ($field)> - return the authid for the authority that should be
linked to the provided MARC::Field object, and a boolean to indicate whether
the match is "fuzzy" (the semantics of "fuzzy" are up to the individual plugin).
In order to handle authority limits, get_link should always end with:
    return $self->SUPER::_handle_auth_limit($authid), $fuzzy;

<flip_heading ($field)> - return a MARC::Field object with the heading flipped
to the preferred form. At present this routine is not used, and can be a stub.

Made the linking functionality use the SearchAuthorities in C4::AuthoritiesMarc
rather than SimpleSearch in C4::Search. Once C4::Search has been refactored,
SearchAuthorities should be rewritten to simply call into C4::Search. However,
at this time C4::Search cannot handle authority searching. Also fixed numerous
performance issues in SearchAuthorities and the Linker script:
* Correctly destroy ZOOM recordsets in SearchAuthorities when finished. If left
  undestroyed, efficiency appears to approach O(log n^n)
* Add an optional $skipmetadata flag to SearchAuthorities that can be used to
  avoid additional calls into Zebra when all that is wanted are authority
  records and not statistics about their use

*** New sysprefs ***
* AutoCreateAuthorities - When this and BiblioAddsAuthorities are both turned
  on, automatically create authority records for headings that don't have
  any authority link when cataloging. When BiblioAddsAuthorities is on and
  AutoCreateAuthorities is turned off, do not automatically generate authority
  records, but allow the user to enter headings that don't match an existing
  authority. When BiblioAddsAuthorities is off, this has no effect.
* CatalogModuleRelink - when turned on, the automatic linker will relink
  headings when a record is saved in the cataloging module when LinkerRelink
  is turned on, even if the headings were manually linked to a different
  authority by the cataloger. When turned off (the default), the automatic
  linker will not relink any headings that have already been linked when a
  record is saved.
* LinkerModule - Chooses which linker module to use for matching headings
  (current options are as described above in the section on linker options:
  "Default," "FirstMatch," and "LastMatch")
* LinkerOptions - A pipe-separated list of options to set for the authority
  linker (at the moment, the only option available is "broader_headings," which
  is described below)
* LinkerRelink - When turned on, the linker will confirm the links for headings
  that have previously been linked to an authority record when it runs. When
  turned off, any heading with an existing link will be ignored.
* LinkerKeepStale - When turned on, the linker will never *delete* a link to an
  authority record, though, depending on the value of LinkerRelink, it may
  change the link.

*** Other changes ***
* Cleaned up authorities code by removing unused functions and adding
  unimplemented functions and added some unit tests.

* This patch also modifies the authority indexing to remove trailing punctuation
  from Match indexes.

* Replace the old BiblioAddAuthorities subroutines with calls into the new
  C4::Linker routines.

* Add a simple implementation for C4::Heading::UNIMARC. (With thanks to F.
  Demians, 2011.01.09) Correct C4::Heading::UNIMARC class loading. Create
  biblio tag to authority types data structure at initialization rather than
  querying DB.

* Ran perltidy on all changed code.

*** Linker Options ***
Enter "broader_headings" in LinkerOptions. With this option, the linker will
try to match the following heading as follows:
=600  10$aCamins-Esakov, Jared$xCoin collections$vCatalogs$vEarly works to
1800.

First: Camins-Esakov, Jared--Coin collections--Catalogs--Early works to 1800
Next: Camins-Esakov, Jared--Coin collections--Catalogs
Next: Camins-Esakov, Jared--Coin collections
Next: Camins-Esakov, Jared (matches! if a previous attempt had matched, it
would not have tried this)

This is probably relevant only to MARC21 and LCSH, but could potentially be of
great use to libraries that make heavy use of floating subdivisions.

=== TESTING PLAN ===

Note: all of these tests require that you have some authority records,
preferably for headings that actually appear in your bibliographic data. At
least one authority record must contain a "see from" reference (remember which
one contains this, as you'll need it for some of the tests). The number shown
in the "Used in" column in the authority module is populated using Zebra
searches of the bibliographic database, so you *must* have
rebuild_zebra.pl -b -z [-x] running in cron, or manually run it after running
the linker.

*** Testing the Heading match in the cataloging plugin ***
1.  Create a new record, and open the cataloging plugin for an
    authority-controlled field.
2.  Search for an authority by entering the "see from" term in the Heading Match
    box
3.  Confirm that the appropriate heading shows up
4.  Search for an authority by entering the preferred heading into the Main
    entry or Main entry ($a only) box (i.e., repeat the procedure you usually
    use for cataloging, whatever that may be)
5.  Confirm that the appropriate heading shows up

*** Testing the cataloging interface ***
6.  Turn off BiblioAddsAuthorities
7.  Confirm that you cannot enter text directly in an authority-controlled field
8.  Confirm that if you search for a heading using the authority control plugin
    the heading is inserted (note, however, that this patch does not AND IS NOT
    INTENDED TO fix the bugs in the authority plugin with duplicate subfields;
    those are wholly out of scope- this check is for regressions)
9.  Turn on BiblioAddsAuthorities and AutoCreateAuthorities
10. Confirm that you can enter text directly into an authority-controlled field,
    and if you enter a heading that doesn't currently have an authority record,
    an authority record stub is automatically created, and the heading you
    entered linked
11. Confirm that if you enter a heading with only a subfield $a that fully
    *matches* an existing heading (i.e. the existing heading has only
    subfield $a populated), the authid for that heading is inserted into
    subfield $9
12. Confirm that if you enter a heading with multiple subfields that *matches*
    an existing heading, the authid for that heading is inserted into
    subfield $9
13. Turn on BiblioAddsAuthorities and turn off AutoCreateAuthorities
14. Confirm that you can enter text directly into an authority-controlled field,
    and if you enter a heading that doesn't currently have an authority record,
    an authority record stub is *not* created
15. Confirm that if you enter a heading with only a subfield $a that *matches*
    an existing heading, the authid for that heading is inserted into
    subfield $9
16. Confirm that if you enter a heading with multiple subfields that *matches*
    an existing heading, the authid for that heading is inserted into
    subfield $9
17. Create a record and link an authority record to an authorized field using
    the authority plugin.
18. Save the record. Ensure that the heading is linked to the appropriate
    authority.
19. Open the record. Change the heading manually to something else, leaving
    the link. Save the record.
20. Ensure that the heading remains linked to that same authority.
21. Change CatalogModuleRelink to "on."
22. Open the record. Use the authority plugin to link that heading to the
    same authority record you did earlier.
23. Save the record. Ensure that the heading is linked to the appropriate
    authority.
24. Open the record. Change the heading manually to something else, leaving
    the link. Save the record.
25. Ensure that the heading is no longer linked to the old authority record.

*** Testing link_bibs_to_authorities.pl ***
26. Set LinkerModule to "Default," turn on LinkerRelink and
    BiblioAddsAuthorities, and turn AutoCreateAuthorities and
    LinkerKeepStale off
27. Edit one bib record so that an authority controlled field that has already
    been linked (i.e. has data in $9) has a heading that does not match any
    authority record in your database
28. Run misc/link_bibs_to_authorities.pl --link-report --verbose --test (you may
    want to pipe the output into less or a file, as the result is quite a lot of
    information)
29. Look over the report to see if the headings that you have authority records
    for report being matched, that the heading you modified in step 2 is
    reported as "unlinked," and confirm that no changes were actually made to
    the database (to check this, look at the bib record you edited earlier, and
    check that the authid in the field you edited hasn't changed)
30. Run misc/link_bibs_to_authorities.pl --link-report --verbose (you may want
    to pipe the output into less or a file, as the result is quite a lot of
    information)
31. Check that the heading you modified has been unlinked
32. Change the modified heading back to whatever it was, but don't use the
    authority control plugin to populate $9
33. Run misc/link_bibs_to_authorities.pl --link-report --verbose
    --bib-limit="biblionumber=${BIB}" (replacing ${BIB} with the biblionumber
    of the record you've been editing)
34. Confirm that the heading has been linked to the correct authority record
35. Turn LinkerKeepStale on
36. Change that heading to something else
37. Run misc/link_bibs_to_authorities.pl --link-report --verbose
    --bib-limit="biblionumber=${BIB}" (replacing ${BIB} with the biblionumber
    of the record you've been editing)
38. Confirm that the $9 has not changed
39. Turn LinkerKeepStale off
40. Create two authorities with the same heading
41. Run misc/migration_tools/rebuild_zebra.pl -a -z
42. Enter that heading into the bibliographic record you are working with
43. Run misc/link_bibs_to_authorities.pl --link-report --verbose
    --bib-limit="biblionumber=${BIB}" (replacing ${BIB} with the biblionumber
    of the record you've been editing)
44. Confirm that the heading has not been linked
45. Change LinkerModule to "FirstMatch"
46. Run misc/link_bibs_to_authorities.pl --link-report --verbose
    --bib-limit="biblionumber=${BIB}" (replacing ${BIB} with the biblionumber
    of the record you've been editing)
47. Confirm that the heading has been linked to the first authority record it
    matches
48. Change LinkerModule to "LastMatch"
49. Run misc/link_bibs_to_authorities.pl --link-report --verbose
    --bib-limit="biblionumber=${BIB}" (replacing ${BIB} with the biblionumber
    of the record you've been editing)
50. Confirm that the heading has been linked to the second authority record it
    matches
51. Run misc/link_bibs_to_authorities.pl --link-report --verbose
    --auth-limit="authid=${AUTH}" (replacing ${AUTH} with an authid)
52. Confirm that only that heading is displayed in the report, and only those
    bibs with that heading have been changed

If all those things worked, good news! You're ready to sign off on the patch
for bug 7284.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on latest master and squashed follow-up, 16 February 2012
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on latest master, 21 February 2012

Signed-off-by: schuster <dschust1@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Tested with an UNIMARC setup that things work fine. They do

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Cherry-picked onto 3.6.x, 10 March 2012
Note for RMaint: this patch squashes all the bug 7284 patches from Master,
including the updatedatabase changes (but does not set the DB revision).

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoUpdating Version Number to 3.06.04.000 v3.06.04
Chris Nighswonger [Sun, 4 Mar 2012 21:32:13 +0000 (16:32 -0500)]
Updating Version Number to 3.06.04.000

12 years ago3.6.4 Translation Update
Frédéric Demians [Thu, 1 Mar 2012 15:20:09 +0000 (16:20 +0100)]
3.6.4 Translation Update
(cherry picked from commit 0f661c5fdec98d18f384a64205ed014d98704111)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agoBug 6895 Diacritics in Pootle/po files are broken in source text
Frédéric Demians [Fri, 24 Feb 2012 12:04:05 +0000 (13:04 +0100)]
Bug 6895 Diacritics in Pootle/po files are broken in source text

To test:

  git checkout 3.6.x
  cd misc/translator
  ./tmpl_process3.pl update -i ../../koha-tmpl/opac-tmpl/prog/en/ \
    -s ./po/fr-FR-i-opac-t-prog-v-3006000.po -r

  po/fr-FR-i-opac-t-prog-v-3006000.po contains broken diacritics for NORMARC
  strings for example
(cherry picked from commit e5871014de68161bd89a8fdcdb5aa7a4c1b9b038)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agoFixing up release notes to reflect all reverts
Chris Nighswonger [Wed, 22 Feb 2012 20:24:05 +0000 (15:24 -0500)]
Fixing up release notes to reflect all reverts

12 years agoRelease Notes for 3.06.04.000 22 Feb 2012 20:14:40 Z
Chris Nighswonger [Wed, 22 Feb 2012 20:14:40 +0000 (15:14 -0500)]
Release Notes for 3.06.04.000 22 Feb 2012 20:14:40 Z

12 years agoRevert "Bug 6875 de-nesting C4::Koha.pm"
Chris Nighswonger [Wed, 22 Feb 2012 19:44:29 +0000 (14:44 -0500)]
Revert "Bug 6875 de-nesting C4::Koha.pm"

This reverts commit c29850630d22c75bd85352b8bd169158f23eaa89.
-Unstable code

12 years agoRevert "Bug 6875 cleaning mainpage.pl"
Chris Nighswonger [Wed, 22 Feb 2012 19:44:06 +0000 (14:44 -0500)]
Revert "Bug 6875 cleaning mainpage.pl"

This reverts commit b21eda0d42b3f2d10c77d17f4a5ac4960b4ada4f.
-Unstable code

12 years agoRevert "Bug 6875 cleaning opac-main.pl"
Chris Nighswonger [Wed, 22 Feb 2012 19:43:43 +0000 (14:43 -0500)]
Revert "Bug 6875 cleaning opac-main.pl"

This reverts commit 27c4844a59cb603ad334d286fba7f32ea1eb72e1.
-Unstable code

12 years agoRevert "Bug 6875 de-nesting C4/Serials"
Chris Nighswonger [Wed, 22 Feb 2012 19:43:20 +0000 (14:43 -0500)]
Revert "Bug 6875 de-nesting C4/Serials"

This reverts commit e84d5a7b37ebf4b47e01da3c504bbabe031c37e1.
-Unstable code

12 years agoRevert "Bug 6875 de-nesting C4::Heading"
Chris Nighswonger [Wed, 22 Feb 2012 19:42:56 +0000 (14:42 -0500)]
Revert "Bug 6875 de-nesting C4::Heading"

This reverts commit 0e61cfb3a591aec28521f2fdd1a76fea904721ca.
-Unstable code

12 years agoRevert "Bug 6875 de-nesting C4::VirtualShelves"
Chris Nighswonger [Wed, 22 Feb 2012 19:42:33 +0000 (14:42 -0500)]
Revert "Bug 6875 de-nesting C4::VirtualShelves"

This reverts commit 6eb50992e85146dbc021493d290de7294355c646.
-Unstable code

12 years agoRevert "Bug 6875 de-nesting Auth.pm"
Chris Nighswonger [Wed, 22 Feb 2012 19:42:08 +0000 (14:42 -0500)]
Revert "Bug 6875 de-nesting Auth.pm"

This reverts commit 34d8c9765fa6b68e0c38be65d863c9bdd4b6a168.
-Unstable code

12 years agoRevert "Bug 7546 - cannot view subscription detail"
Chris Nighswonger [Wed, 22 Feb 2012 19:40:41 +0000 (14:40 -0500)]
Revert "Bug 7546 - cannot view subscription detail"

This reverts commit f6c55445ed2ef6fe5eaf99831b9ec180d12707ec.
-This is related to de-nesting work (Bug 6875) which is unstable

12 years agoRevert "Bug 7545: Can't edit items"
Chris Nighswonger [Wed, 22 Feb 2012 19:39:03 +0000 (14:39 -0500)]
Revert "Bug 7545: Can't edit items"

This reverts commit 57f25c57f02f260da08fe527308e1f5a5a01c8c7.
-Tied to de-nesting work (Bug 6875) which is unstable

12 years agoBug 7535: ampersands not showing properly in non-XSLT OPAC
D Ruth Bavousett [Mon, 13 Feb 2012 15:25:40 +0000 (10:25 -0500)]
Bug 7535: ampersands not showing properly in non-XSLT OPAC

Jared's fix for Bug 3326 fixed this in the staff client, but not the OPAC; moving this one line fixes it
both places.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
This can be replicated by indexing with -x
OPACXSLTResults must be set to "normally"
Reproduced original bug with rebuild-zebra.pl -x -b -w -r -v -v
Patch corrects the issue, does not change intranet behavior.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit bbfaf8264c815013cd37155c9aac283e3cb3cc4a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agoFixing release notes to reflect reverted status of several Enh
Chris Nighswonger [Tue, 21 Feb 2012 14:30:21 +0000 (09:30 -0500)]
Fixing release notes to reflect reverted status of several Enh

12 years agoRelease Notes for 3.06.04.000 21 Feb 2012 14:26:00 Z
Chris Nighswonger [Tue, 21 Feb 2012 14:26:00 +0000 (09:26 -0500)]
Release Notes for 3.06.04.000 21 Feb 2012 14:26:00 Z

12 years agoUpdating Version Number to 3.06.03.001
Chris Nighswonger [Tue, 21 Feb 2012 14:20:17 +0000 (09:20 -0500)]
Updating Version Number to 3.06.03.001

12 years agoRevert "Bug 6299 - Provide a list of authorized values for Relator terms"
Chris Nighswonger [Tue, 21 Feb 2012 14:19:15 +0000 (09:19 -0500)]
Revert "Bug 6299 - Provide a list of authorized values for Relator terms"

This reverts commit ed6d4244074e08e28c40ce1fcf48d64492826b9b.
-Reverting Enh 6299

12 years agoRevert "Bug 6299 Add relator codes for fr-FR"
Chris Nighswonger [Tue, 21 Feb 2012 14:18:48 +0000 (09:18 -0500)]
Revert "Bug 6299 Add relator codes for fr-FR"

This reverts commit d5148aac15e6d80a19ad6dfc920ef9993ef7c144.
-Reverting Enh 6299

12 years agoRevert "Bug 6299 - add es-ES"
Chris Nighswonger [Tue, 21 Feb 2012 14:18:14 +0000 (09:18 -0500)]
Revert "Bug 6299 - add es-ES"

This reverts commit fa3a2cbedb24e793bf7ffd1ee8a3deff49010c9e.
-Reverting Enh 6299

12 years agoReverting Enh 6299
Chris Nighswonger [Tue, 21 Feb 2012 14:17:54 +0000 (09:17 -0500)]
Reverting Enh 6299

12 years agoRevert "Updating Version Number to 3.06.03.001"
Chris Nighswonger [Tue, 21 Feb 2012 14:15:14 +0000 (09:15 -0500)]
Revert "Updating Version Number to 3.06.03.001"

This reverts commit 0160ba05ac66e392800aad7caf5734667a223d87.
-Removing enh 6299

12 years agoRevert "Updating Version Number to 3.06.03.002"
Chris Nighswonger [Tue, 21 Feb 2012 14:14:35 +0000 (09:14 -0500)]
Revert "Updating Version Number to 3.06.03.002"

This reverts commit 52d83a16cd636165d1de415ed1398c7f4a414b12.
-Necessary to revert 6299

12 years agoRevert "Bug 7238 Followup - fix sip_run to require path to SIPconfig.xml"
Chris Nighswonger [Tue, 21 Feb 2012 12:51:16 +0000 (07:51 -0500)]
Revert "Bug 7238 Followup - fix sip_run to require path to SIPconfig.xml"

This reverts commit d76424a17cb246107dcfaf45fc41ae327c6b57e1.
-Introduces changes to sip configuration

12 years agoRevert "Bug 7238 : Shifting SIPconfig.xml to the etc dir and the scripts to misc...
Chris Nighswonger [Tue, 21 Feb 2012 12:51:01 +0000 (07:51 -0500)]
Revert "Bug 7238 : Shifting SIPconfig.xml to the etc dir and the scripts to misc/bin"

This reverts commit 36cf50e27d39bc60c1a4fc4d76e88e5a088657bc.
-Introduces changes to sip configuration

12 years agoRevert "Bug 7238 - make packages deal with SIP config"
Chris Nighswonger [Tue, 21 Feb 2012 12:50:47 +0000 (07:50 -0500)]
Revert "Bug 7238 - make packages deal with SIP config"

This reverts commit 6b6440ad79c0614a94686ecc3a71d78f541e7efe.
-Introduces changes to sip configuration

12 years agoBug 6488 - followup - fixes issue with bibs with no items and serials being suppressed
Liz Rea [Fri, 17 Feb 2012 20:00:53 +0000 (14:00 -0600)]
Bug 6488 - followup - fixes issue with bibs with no items and serials being suppressed

To test:

* create a bib with no items
* update your index
serial records and your new bib with no items should be displayed.
* add something to the OPACHiddenItems syspref (I like itype: [BK] from the test data)
*** test both ways, with something in there and with the syspref empty.
* add an item to your new bib that would be suppressed
* update your index
* search for the bib
The item should not show
* change the item into a state where it would no longer be suppressed
* update your index
* search for the bib
The item should show in the opac
* just for fun, delete your item
* update your index
* Search for the bib - it should still display.

I tested on MARC21 - please test UNIMARC as well.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
(cherry picked from commit 2a8fe16752e12505c55c9f8c08afe97afe460f7b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agoRelease Notes for 3.06.04.000 20 Feb 2012 19:45:25 Z
Chris Nighswonger [Mon, 20 Feb 2012 19:45:25 +0000 (14:45 -0500)]
Release Notes for 3.06.04.000 20 Feb 2012 19:45:25 Z

12 years agoRevert "Bug 6836: Add jQuery dataTables plugin"
Chris Nighswonger [Mon, 20 Feb 2012 19:44:30 +0000 (14:44 -0500)]
Revert "Bug 6836: Add jQuery dataTables plugin"

This reverts commit 5f36947783cbe43a9550b3ffc839a2956d59ae94.

-Part of Enh 6836

12 years agoRevert "Bug 6836: followup CSS work"
Chris Nighswonger [Mon, 20 Feb 2012 19:44:00 +0000 (14:44 -0500)]
Revert "Bug 6836: followup CSS work"

This reverts commit 8edc97a838f8ee49c099e3870a15e43d554e2b63.

-Part of enh 6836

12 years agoRevert "Bug 6836: test case readingrec.pl"
Chris Nighswonger [Mon, 20 Feb 2012 19:43:34 +0000 (14:43 -0500)]
Revert "Bug 6836: test case readingrec.pl"

This reverts commit 0508e6fb86a48c8b99fdc63ccb2ebb1d5133c95a.

-Part of Enh 6836

12 years agoRevert "Bug 6836 follow-up fixing POD"
Chris Nighswonger [Mon, 20 Feb 2012 19:43:01 +0000 (14:43 -0500)]
Revert "Bug 6836 follow-up fixing POD"

This reverts commit 03e1c36dce6dc37f47c0927517b8bf646c214557.

-Part of Enh 6836

12 years agoRevert "Bug 6838: Add pagination and filtering on subscriptions table"
Chris Nighswonger [Mon, 20 Feb 2012 19:39:09 +0000 (14:39 -0500)]
Revert "Bug 6838: Add pagination and filtering on subscriptions table"

This reverts commit e13db856d4ceac1bb9b195dd10391cd239c19296.

-Part of DataTables Enhancement

12 years agoUpdating Version Number to 3.06.03.002
Chris Nighswonger [Mon, 20 Feb 2012 19:27:42 +0000 (14:27 -0500)]
Updating Version Number to 3.06.03.002

12 years agobug_7090: AllowItemsOnHandCheckout syspref
Srdjan Jankovic [Wed, 21 Dec 2011 08:26:30 +0000 (21:26 +1300)]
bug_7090: AllowItemsOnHandCheckout syspref

Observe AllowItemsOnHandCheckout syspref when using SIP self checkout

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
To test:
* place an item on hold for patron A
* attempt to circulate that item to patron B (via SIP/selfcheck)
syspref off: item should not circulate to patron B
Syspref On: item should circulate to patron B

Both conditions passed in our testing.
Also verified that normal staff client behavior regarding this situation was preserved. It was.

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
-backported to 3.6.x

12 years agoBug 7357: display serial title instead of '---'
Adrien Saurat [Mon, 9 Jan 2012 10:55:08 +0000 (11:55 +0100)]
Bug 7357: display serial title instead of '---'

The full title of a serial is now displayed even
if several lines have the same title.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit cb1a9466931790bbe3aac19845a3c7b441e43ea2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agoBug 6137 follow-up, moving new test to db_dependent directory
Paul Poulain [Fri, 17 Feb 2012 17:40:33 +0000 (18:40 +0100)]
Bug 6137 follow-up, moving new test to db_dependent directory
(cherry picked from commit 46a5154df940cf10e6718aa87717fdb87ebca702)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agoBug 6137: unit tests for C4::Circulation::_GetCircControlBranch
Julian Maurice [Fri, 27 Jan 2012 14:59:36 +0000 (15:59 +0100)]
Bug 6137: unit tests for C4::Circulation::_GetCircControlBranch

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 76be6208eeafbeb555103570f1484a64a7a12394)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agoBug 6137: fix a Circulation bug. userenv null
biblibre [Tue, 8 Mar 2011 09:28:38 +0000 (10:28 +0100)]
Bug 6137: fix a Circulation bug. userenv null

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f4a5206ae059132f9623e1873c2450fa6152206a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agoBug 7532 - remove dependency on Date::ICal
Robin Sheat [Sun, 12 Feb 2012 03:36:34 +0000 (16:36 +1300)]
Bug 7532 - remove dependency on Date::ICal

This removes the dependency on Date::ICal (which is largely
unmaintained) and replaces it with DateTime::Format::ICal which can do
the same job. It also updates all the docs and installation scripts to
handle this change.

Note that this causes a minor behaviour change: previously the generated
times were converted to UTC, now they are left "floating" (that is, have
no timezone attached) and so will appear as the local time when imported
into a calendar. I don't anticipate this'll cause any issues however.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
(cherry picked from commit 70d95b515e491e5526c7276f0af03d51ff236d40)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agoBug 7514 Choose OPAC language with URL parameter
Frédéric Demians [Thu, 9 Feb 2012 10:03:34 +0000 (11:03 +0100)]
Bug 7514 Choose OPAC language with URL parameter

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested:
- with and without cookie set
- different language codes

http://.../cgi-bin/koha/opac-changelanguage.pl?language=de-DE
will directly open the German OPAC.

http://.../cgi-bin/koha/opac-changelanguage.pl?language=en
will directly open the English OPAC.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 8ec812d97de321d8100f8e80ccad06cc36840e12)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agobug_7458: A call number plugin
Srdjan Jankovic [Wed, 8 Feb 2012 02:12:05 +0000 (15:12 +1300)]
bug_7458: A call number plugin

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
A library using an inhouse callnumbering system wants to be able to generate the next available call number not already in use.  This custom call number plugin returns the next callnumber not already in use once a correct prefix has been entered.  The prefixes are four to six letters, space, then one or two numbers.
(cherry picked from commit ecc1e94f35491ba392aa3bfd17118c55fa14e55b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agoBug 7409 - add unzip and perl-doc dependencies to package
Robin Sheat [Fri, 10 Feb 2012 03:10:28 +0000 (16:10 +1300)]
Bug 7409 - add unzip and perl-doc dependencies to package

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 4e8cd9a9ddd3c76745a5102498d8836457173db5)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agoBug 7312: Adds ISSN to serials/subscription-bib-search.pl results
Matthias Meusburger [Thu, 12 May 2011 09:29:01 +0000 (11:29 +0200)]
Bug 7312: Adds ISSN to serials/subscription-bib-search.pl results

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 91d0475a9b43dc3fbe6b373dc8dacd5db4bca9df)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agoBug 7289: Add biblioitems.editionstatement to missing sql files
Katrin Fischer [Sun, 12 Feb 2012 18:27:57 +0000 (19:27 +0100)]
Bug 7289: Add biblioitems.editionstatement to missing sql files

Follow-up for 7289 adding the new mapping to translated frameworks.

http://bugs.koha-community.org/show_bug.cgi?id=7280

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
(cherry picked from commit 72616e4f3fa85f65741f8bd50f06408428bc60c5)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agoBug 7246 add offset/length and where options to rebuild_zebra
Paul Poulain [Wed, 1 Feb 2012 14:15:02 +0000 (15:15 +0100)]
Bug 7246 add offset/length and where options to rebuild_zebra

This patch reimplement a feature that is on biblibre/master for Koha-community/master

It adds 4 parameters:
* offset = the offset of record. Say 1000 to start rebuilding at the 1000th record of your database
* length = how many records to export. Say 400 to export only 400 records
* where = add a where clause to rebuild only a given itemtype, or anything you want to filter on

Another improvement resulting from offset & length limit is the rebuild_zebra_sliced.zsh
that will be submitted in another patch.
rebuild_zebra_sliced will slice your all database in small chunks, and, if something went wrong for a given slice, will slice the slice, and repeat, until you reach a slice size of 1, showing which record is wrong in your database.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Removed mention of -l option for limiting number of items exported, as requested
by QA manager. This can be re-added in a later patch.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 1fd8c8a4debf750476a2369e4440ac662b19f6b7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agoBug 7201 follow-up, fixing some indentation mistakes
Paul Poulain [Fri, 17 Feb 2012 09:58:01 +0000 (10:58 +0100)]
Bug 7201 follow-up, fixing some indentation mistakes
(cherry picked from commit 647843c3bba2fcd30b972e95b5b1952f38ff4ca0)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agobug_7201: Holds reports: add copynumber and enumchron
Srdjan Jankovic [Thu, 9 Feb 2012 00:24:35 +0000 (13:24 +1300)]
bug_7201: Holds reports: add copynumber and enumchron

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Data is there and correct - very helpful patch, thanks!
passes prove t xt t/db_dependent in line with current master failures.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 8b80b315c3689bd58bee4cb5fc3c0d843bd080eb)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agoBug 6985 - remove kw,wrdl from the search results
Liz Rea [Wed, 25 Jan 2012 20:41:03 +0000 (14:41 -0600)]
Bug 6985 - remove kw,wrdl from the search results

To test:

* Apply patch
* Do a search in the OPAC, the result page should now say
  "Your search returned X results" instead of
  "Your search for "kw,wrdl:yyy" returned x results"
* Do a search that will have no results, kw,wrdl should not appear in the text.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Adrien Saurat <adrien.saurat@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 4490650e2fc5dd4da6bd2e339434f1366beb610d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
12 years agoBug 5346: Small display changes
Katrin Fischer [Mon, 23 Jan 2012 06:43:11 +0000 (07:43 +0100)]
Bug 5346: Small display changes

Changing display from:
Suggested by Admin, Koha (from suggestion #2)

To:
Suggested by: Admin, Koha (suggestion #2)

Adding some missing parentheses and deleting some additional spaces.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit b5f7a1f8771fb0d98db3b39f1ef6315783c30238)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>