From 750950c17a243dbec1001ef8b6a17f2a13f45bcb Mon Sep 17 00:00:00 2001 From: Mirko Tietgen Date: Tue, 16 Jul 2013 21:51:01 +0200 Subject: [PATCH] Bug 10595: don't display OpacTopissue page when system preference is turned off When the syspref is turned off, the link is hidden but the page is still accessible. This patch checks the syspref and redirects to 404 if it is disabled. Test plan: Before applying the patch Enable OpacTopissue Observe there is a link to opac-topissues.pl next to Advanced search etc. Follow that link, observe that opac-topissues.pl is loading Disable OpacTopissue Observe the link is gone Manually open /koha/opac-topissues.pl and check that it is loading even though the feature is disabled Apply patch (OpacTopissue still diabled) Manually open /koha/opac-topissues.pl and observe that you are being redirected to the 404 page. Enable OpacTopissue Follow the link or manuall open opac-topissues.pl and check that it is working Signoff the patch. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 04ca81bc358f1bc6425e1cef431d9e4abfc744d8) Signed-off-by: Tomas Cohen Arazi Works as expected (cherry picked from commit 094bfd0d17689c92a4e9366af63ffb7fcbe99399) Signed-off-by: Bernardo Gonzalez Kriegel (cherry picked from commit 094bfd0d17689c92a4e9366af63ffb7fcbe99399) Signed-off-by: Chris Hall (cherry picked from commit d92e6c746de1060a34631f4a0eea7bc71b110cd8) --- opac/opac-topissues.pl | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/opac/opac-topissues.pl b/opac/opac-topissues.pl index 40c7a7fc52..9b938582a6 100755 --- a/opac/opac-topissues.pl +++ b/opac/opac-topissues.pl @@ -40,6 +40,13 @@ plugin that shows a stats on borrowers =cut my $input = new CGI; + +# if OpacTopissue is disabled, leave immediately +if ( ! C4::Context->preference('OpacTopissue') ) { + print $input->redirect("/cgi-bin/koha/errors/404.pl"); + exit; +} + my $branches = GetBranches(); my $itemtypes = GetItemTypes(); -- 2.39.5