]> git.koha-community.org Git - koha.git/commit
Bug 31144: When modifying an order we should not load the vendor default discount
authorNick Clemens <nick@bywatersolutions.com>
Tue, 12 Jul 2022 18:39:06 +0000 (18:39 +0000)
committerArthur Suzuki <arthur.suzuki@biblibre.com>
Fri, 26 Aug 2022 12:52:33 +0000 (14:52 +0200)
commitdbeefd1f2ab45ca6b0b267840913386716b5415f
tree6494acbcf6f6d5c71eadb2ab8f4f3e33a857c1e1
parent731c9dd7c90fab24a6c137c9946756123710feb5
Bug 31144: When modifying an order we should not load the vendor default discount

After placing an order in a basket with a discount of "0" if you attempt to modify we will load the vendor default discount, this can lead to accidentally applying a discount when modifying other order parts

To test:
0 - Have a vendor with a discount set
1 - Add an order to a basket
2 - While adding, set discount to 0
3 - Add order - prices are calculated ocrrectly
4 - Modify order
5 - Note discount is populated with vendor discount
6 - Cancel
7 - Apply patch
8 - Modify order
9 - Discount remains at 0
10 - Repeat with a vendor with no discount set
11 - Placing order not specifiying discount it remains blank
12 - Modifying order discount remains blank
13 - Modify order and set discount
14 - Confirm it is retained on modifcation

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 73d2066837e5f73e44c89952497d12e6f1d13342)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit f92f6a315d8b89a7da65cb24f85edea2963ecbfe)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt