From 2af6bbbe5dd5b0152c65296ee0298b7f5431d79c Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Tue, 2 Jul 2024 10:45:08 +0000
Subject: [PATCH] Bug 37229: Fix table configuration listings for course
 reserves

This patch changes the structure of columns_settings.yml so that the
configuration of tables on opac-course-details.pl and
opac-course-reserves.pl are in separate sections. They should not be
grouped under "biblio-detail" (opac-detail.pl).

To test you should have at least one course defined and some items
attached to that course.

- Apply the patch and restart services.
- Go to Administration -> Table settings -> OPAC
- You should see "Jump to" links for biblio-detail, course_items, and
  course_list.
- Make some changes to the course_items and course_list configurations.
- Go to the OPAC and confirm that your changes are reflected in the
  visible columns of those tables.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 admin/columns_settings.yml                    | 28 ++++++++++---------
 .../en/modules/opac-course-details.tt         |  2 +-
 .../en/modules/opac-course-reserves.tt        |  2 +-
 3 files changed, 17 insertions(+), 15 deletions(-)

diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml
index 5999889ce1..af24061dcf 100644
--- a/admin/columns_settings.yml
+++ b/admin/columns_settings.yml
@@ -2028,6 +2028,20 @@ modules:
             -
               columnname: item_coursereserves
 
+      subscriptionst:
+        columns:
+            -
+              columnname: serial_serialseq
+            -
+              columnname: serial_publisheddate
+            -
+              columnname: serial_planneddate
+            -
+              columnname: serial_status
+            -
+              columnname: serial_notes
+
+    course_list:
       course_reserves_table:
         columns:
             -
@@ -2045,19 +2059,7 @@ modules:
             -
               columnname: notes
 
-      subscriptionst:
-        columns:
-            -
-              columnname: serial_serialseq
-            -
-              columnname: serial_publisheddate
-            -
-              columnname: serial_planneddate
-            -
-              columnname: serial_status
-            -
-              columnname: serial_notes
-
+    course_items:
       course-items-table:
         columns:
             -
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt
index b7354fdb96..5ce9a87fa4 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt
@@ -123,7 +123,7 @@
     [% INCLUDE 'columns_settings.inc' %]
     <script>
         $(document).ready(function() {
-            columns_settings = [% TablesSettings.GetColumns( 'opac', 'biblio-detail', 'course-items-table', 'json' ) | $raw %];
+            columns_settings = [% TablesSettings.GetColumns( 'opac', 'course_items', 'course-items-table', 'json' ) | $raw %];
             KohaTable("#course-items-table", {
                 "dom": '<"top"<"table_controls"f>>t',
                 "sorting": [[ 1, "asc" ]],
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt
index 8924690baa..b6e67303f3 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt
@@ -73,7 +73,7 @@
     [% INCLUDE 'columns_settings.inc' %]
     <script>
         $(document).ready(function() {
-            columns_settings = [% TablesSettings.GetColumns( 'opac', 'biblio-detail', 'course_reserves_table', 'json' ) | $raw %]
+            columns_settings = [% TablesSettings.GetColumns( 'opac', 'course_list', 'course_reserves_table', 'json' ) | $raw %]
             KohaTable("#course_reserves_table", {
                 "dom": '<"top"f>rt<"clear">',
                 "sorting": [[ 1, "asc" ]],
-- 
2.39.5