From 52f91af5bcd3ca4ec82463764dcaace6dcc0b2ae Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Fri, 8 May 2020 13:15:40 -0400
Subject: [PATCH] Bug 25430: Improve the styling of the claims returned tab

It has been suggested that it would be useful to add title attributes to the different numbers on the return claims tab in the checkouts and patron details pages. In addition, color coding them ( and removing the slash ) will make the numbers easier to read.

Test Plan:
1) Set up return claims for your system
2) Apply this patch
3) View the claims tab for someone with not claims, and someone with claims
4) Note the resolved claims are green and have a "tooltip" when hovered over
5) Note the unresolved claims are green if 0, and yellow if not 0, and
   also have a "tooltip"

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../intranet-tmpl/prog/en/modules/circ/circulation.tt  | 10 ++++------
 .../prog/en/modules/members/moremember.tt              | 10 ++++------
 2 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
index 682573dc0a..5172a2435d 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
@@ -873,17 +873,15 @@
                                 <li>
                                     [% IF ( patron.return_claims.count ) %]
                                         <a href="#return-claims" id="return-claims-tab">
-                                            <span id="return-claims-count-resolved">[% patron.return_claims.resolved.count | html %]</span>
-                                            /
-                                            <span id="return-claims-count-unresolved">[% patron.return_claims.unresolved.count | html %]</span>
                                             Claim(s)
+                                            <span title="Resolved claims" class="label label-success" id="return-claims-count-resolved">[% patron.return_claims.resolved.count | html %]</span>
+                                            <span title="Unresolved claims" class="label label-warning" id="return-claims-count-unresolved">[% patron.return_claims.unresolved.count | html %]</span>
                                         </a>
                                     [% ELSE %]
                                         <a href="#return-claims" id="return-claims-tab">
-                                            <span id="return-claims-count-resolved">0</span>
-                                            /
-                                            <span id="return-claims-count-unresolved">0</span>
                                             Claim(s)
+                                            <span title="Resolved claims" class="label label-success" id="return-claims-count-resolved">0</span>
+                                            <span title="Unresolved claims" class="label label-success" id="return-claims-count-unresolved">0</span>
                                         </a>
                                     [% END %]
                                 </li>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
index d18bf5d558..20a4b991e4 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
@@ -763,17 +763,15 @@
                                 <li>
                                     [% IF ( patron.return_claims.count ) %]
                                         <a href="#return-claims" id="return-claims-tab">
-                                            <span id="return-claims-count-resolved">[% patron.return_claims.resolved.count | html %]</span>
-                                            /
-                                            <span id="return-claims-count-unresolved">[% patron.return_claims.unresolved.count | html %]</span>
                                             Claim(s)
+                                            <span title="Resolved claims" class="label label-success" id="return-claims-count-resolved">[% patron.return_claims.resolved.count | html %]</span>
+                                            <span title="Unresolved claims" class="label label-warning" id="return-claims-count-unresolved">[% patron.return_claims.unresolved.count | html %]</span>
                                         </a>
                                     [% ELSE %]
                                         <a href="#return-claims" id="return-claims-tab">
-                                            <span id="return-claims-count-resolved">0</span>
-                                            /
-                                            <span id="return-claims-count-unresolved">0</span>
                                             Claim(s)
+                                            <span title="Resolved claims" class="label label-success" id="return-claims-count-resolved">0</span>
+                                            <span title="Unresolved claims" class="label label-success" id="return-claims-count-unresolved">0</span>
                                         </a>
                                     [% END %]
                                 </li>
-- 
2.39.5