]> git.koha-community.org Git - koha.git/commit
Bug 11791 - Use validation plugin when creating new city
authorOwen Leonard <oleonard@myacpl.org>
Wed, 19 Feb 2014 16:36:30 +0000 (11:36 -0500)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 21 May 2014 08:12:17 +0000 (10:12 +0200)
commit1e6c33c41b1b6c94bb8bc84626ed64da42abe6d5
treecf2614a62d57947f4d14f5bd671d386939a97f1d
parent865e58399ca0bd6f1ce27a1323b75ffa99cefe2a
Bug 11791 - Use validation plugin when creating new city

The page for adding a new city includes some custom form
validation JavaScript which can be removed in favor of HTML5 validation
attributes and Koha's built-in validation plugin. This patch does so.

To test, apply the patch and go to Administration -> Cities -> New city.
Try submitting the form without entering a city or zip code. This should
trigger a validation warning.

Submission of the form with valid data should work correctly. Editing an
existing city should also work correctly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Note: This patch changes the behavior. Before the patch, only 1 out of city
and zip was required. Now both are. Since the 2 inputs were marked as
required, I think they should be.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit d95ad086a35a7927bb7bc02453a1a1341387dc6a)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt