]> git.koha-community.org Git - koha.git/commit
Bug 9136: C4::Tags not Plack-compatible
authorJared Camins-Esakov <jcamins@cpbibliography.com>
Fri, 23 Nov 2012 19:14:16 +0000 (14:14 -0500)
committerChris Cormack <chrisc@catalyst.net.nz>
Wed, 26 Dec 2012 19:40:31 +0000 (08:40 +1300)
commit9dab59dfb97ab0ba37d1d4d23acfd41e24142514
tree5e1c92cded1ee4fba02c09aa2b4d420a329c3eeb
parentfde0fb58df129498aec306847c02ecc7c04a3013
Bug 9136: C4::Tags not Plack-compatible

The three module-scoped variables $ext_dict, @fields, and $select_all
were preventing tagging code from working under Plack. I fixed this
by changing the latter two to compile-time constants, and declared the
first with "our $ext_dict;"

To test (under Plack):
1) Try to create a tag before the patch is applied. Note that you get a
   500 error in the AJAX request.
2) Apply patch.
3) Repeat step (1), noticing that this time the tag is created and there
   is no error.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
C4/Tags.pm