]> git.koha-community.org Git - koha.git/commit
Bug 37623: Make t/db_dependent/Letters.t idempotent
authorAleisha Amohia <aleishaamohia@hotmail.com>
Tue, 13 Aug 2024 03:07:17 +0000 (03:07 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Mon, 19 Aug 2024 15:29:53 +0000 (17:29 +0200)
commit0e61e56e5728fc0ed387e9a53f40a6e77e9bc793
tree3280043bb70f2e1baba37483a7a53aede0e0d3b3
parent42b197679e335090ba46432ad9febd7915d3d806
Bug 37623: Make t/db_dependent/Letters.t idempotent

The tests should be unaffected by system preference settings, such as EmailFieldPrimary.

To test:
1. Log into the staff interface
2. Go to Koha Administration -> Global system preferences, and search for EmailFieldPrimary
3. Change the EmailFieldPrimary preference to something other than 'primary email' and 'first valid email address', i.e. any of the following:

* alternate email
* card number
* secondary email
* selected addresses

4. Run tests t/db_dependent/Letters.t and notice they fail

5. Apply the patch

6. Run the tests again t/db_dependent/Letters.t with different settings of EmailFieldPrimary. The tests should always pass.

Sponsored-by: Pymble Ladies' College
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
t/db_dependent/Letters.t