From d680ae35f39c0eb413b45339aadfa9148a58ed55 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 28 May 2020 12:11:37 +0200 Subject: [PATCH] Bug 25615: Remove empty entries in the filter dropdowns of "holds to pull" MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit On the "Holds to pull" view there are filters that are built on the value of the cells. Bug 22536 improved the ergonomic by adding a ul list, but the filters are now broken, the ul and li tags are retrieved and put in the filter list. The idea of this patch is to remove the HTML tags and skip if the value is then empty. Test plan: Place a hold on an item Go to Home › Circulation › Holds to pull Open the "libraries" filter => Without this patch you see empty entries => With this patch the filter contain only the libraries Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 4f70682c56dddd42f24c62d7634f5cd3b7119702) Signed-off-by: Lucas Gass (cherry picked from commit 58c071fad3f63de8e069baa84ddea9656e689913) Signed-off-by: Aleisha Amohia --- .../intranet-tmpl/prog/en/modules/circ/pendingreserves.tt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt index 1510f81ed9..08193e0179 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt @@ -276,8 +276,11 @@ function createSelect( data ) { data = separateData(data); var r=''; } -- 2.39.5