From d7e754ea3c6c3f12f784de84bff4b3da31e4e791 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 18 Jul 2024 07:27:47 -0400 Subject: [PATCH] Bug 37400 - In returns.pl don't search for a patron unless needed In returns.pl we find a patron, then use it in an if statement. Test Plan: Cancel a hold with other holds remaining on the record. No change should be noted. Signed-off-by: Martin Renvoize (cherry picked from commit 82535a488764be5437c47d38953eb0aea81ce4ee) Signed-off-by: Lucas Gass --- circ/returns.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/circ/returns.pl b/circ/returns.pl index f3182464df..72e004a795 100755 --- a/circ/returns.pl +++ b/circ/returns.pl @@ -179,8 +179,8 @@ if ( $query->param('reserve_id') && $op eq 'cud-affect_reserve') { # FIXME do we need to do this if we didn't take the cancel_reserve branch above? my ( undef, $nextreservinfo, undef ) = CheckReserves($item); - my $patron = Koha::Patrons->find( $nextreservinfo->{'borrowernumber'} ); if ( $userenv_branch ne $nextreservinfo->{'branchcode'} ) { + my $patron = Koha::Patrons->find( $nextreservinfo->{'borrowernumber'} ); $template->param( itemtitle => $biblio->title, itembiblionumber => $biblio->biblionumber, -- 2.39.5