]> git.koha-community.org Git - koha.git/commit
Bug 9535 - Patron card creator "Remove duplicates" function doesn't work
authorChris Nighswonger <cnighswonger@foundations.edu>
Tue, 2 Apr 2013 14:05:46 +0000 (10:05 -0400)
committerJared Camins-Esakov <jcamins@cpbibliography.com>
Wed, 3 Apr 2013 10:09:06 +0000 (06:09 -0400)
commitc70c7185dc6b28151fa9a28e4b2aa13a52d9fc23
tree10ff6d95ec8c20164a2fad8b89eeb01386aba933
parent9d784c57ded192e12959f2dfb226aadaf3d6b012
Bug 9535 - Patron card creator "Remove duplicates" function doesn't work

This bug was due to a difference in field names used in the item data
for items versus patrons. This patch adds a ternary to discern between
the two.

To test:

Before applying patch:

1. Create a batch of patroncards with one duplicate.
2. Run the de-duplication on the batch.
3. Note that all patrons beyond the first in the batch are now
   deleted.

After applying patch:
4. Repeat steps 1-2.
5. Note that only the duplicate patron is removed.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Tested successfully with both patron card batches and label batches.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Add indentation for readability
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
C4/Creators/Batch.pm