]> git.koha-community.org Git - koha.git/commit
Bug 5094 auth_by_bind authentication can fail even if given a correct password and...
authorJeremy Crabtree <JeremyC@uta.edu>
Fri, 17 Jun 2011 03:02:50 +0000 (15:02 +1200)
committerChris Nighswonger <chris.nighswonger@gmail.com>
Sun, 19 Jun 2011 19:02:58 +0000 (15:02 -0400)
commitdd34d794b43e99ef172f629eaca3d831669b0ce8
treeeb35b39fd305f0502181e939a47fbc36f80bf13c
parent3ff9a4fafd66a70788e5e6dafb9adb81bb1f3ad0
Bug 5094  auth_by_bind authentication can fail even if given a correct password and userid

When using

<replicate>0</replicate> <!-- add new users from LDAP to Koha database -->
<update>0</update> <!-- update existing users in Koha database ->
<auth_by_bind>1</auth_by_bind> <!-- set to 1 to authenticate by
binding instead of password comparison, e.g., to use Active Directory -->

Auth_with_ldap attempts to lookup the userid in the LDAP directory to
fill $userldapentry despite it being unneeded in this case.  The information
retrieved will be thrown away, thus there is no need to retrieve it.
This can cause authentication to fail overall even if the initial bind with the
user's credentials succeeded

Signed-off-by: Joe Atzberger <ohiocore@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 7bb178e30be74abda82eb4fcaaa873be3dfcc5ef)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
C4/Auth_with_ldap.pm