From d6b5a7f7dfe581715ea34b71bdd4bab72fedc117 Mon Sep 17 00:00:00 2001 From: David Nind Date: Thu, 4 May 2023 20:25:01 +0000 Subject: [PATCH] Bug 33673: Change "global system preferences" to "system preferences" The Koha Community normally refers to "global system preferences" as just "system preferences". This updates the staff interface and other occurences to refelect this, including: - Administration > Global system preferences and the description - Patrons > [a patron] > More > Set permissions > Manage Koha system settings > Manage global system preferences (manage_sysprefs) - The installer files and the database (permissions table) Test plan: 1. Note that in the staff interface "Global system preferences" is dispalyed in two places: 1.1 Administration: Go to Administration. There is a section called "Global system preferences" with a description and a search box. 1.2 User permissions: View the details for a patron > More > Set permissions > expand 'Manage Koha system settings' > scroll down to 'Manage global system preferences (manage_sysprefs)' 2. Apply the patch. 3. Update the database. 4. Revisit the pages in step 1 - these should now show as "System prefereneces" or "system preferences" as appropriate. 5. Sign off! Signed-off-by: David Nind Signed-off-by: Magnus Enger I agree with this change, consistency is good. As far as I can see this patch cathes all the occurrences of "global". Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi --- installer/data/mysql/atomicupdate/bug_33673.pl | 12 ++++++++++++ installer/data/mysql/mandatory/userpermissions.sql | 2 +- .../intranet-tmpl/prog/en/includes/permissions.inc | 2 +- .../prog/en/modules/admin/admin-home.tt | 4 ++-- 4 files changed, 16 insertions(+), 4 deletions(-) create mode 100755 installer/data/mysql/atomicupdate/bug_33673.pl diff --git a/installer/data/mysql/atomicupdate/bug_33673.pl b/installer/data/mysql/atomicupdate/bug_33673.pl new file mode 100755 index 0000000000..6e1dec6086 --- /dev/null +++ b/installer/data/mysql/atomicupdate/bug_33673.pl @@ -0,0 +1,12 @@ +use Modern::Perl; + +return { + bug_number => "33673", + description => "Change \"global system preferences\" to \"system preferences\"", + up => sub { + my ($args) = @_; + my ($dbh, $out) = @$args{qw(dbh out)}; + $dbh->do(q{ UPDATE permissions SET description = 'Manage system preferences' WHERE code = 'manage_sysprefs' }); + say $out "Updated manage_sysprefs permission description."; + }, +}; diff --git a/installer/data/mysql/mandatory/userpermissions.sql b/installer/data/mysql/mandatory/userpermissions.sql index 7b6955de44..0c394f9500 100644 --- a/installer/data/mysql/mandatory/userpermissions.sql +++ b/installer/data/mysql/mandatory/userpermissions.sql @@ -10,7 +10,7 @@ INSERT INTO permissions (module_bit, code, description) VALUES ( 3, 'manage_accounts', 'Manage Account Debit and Credit Types' ), ( 3, 'manage_circ_rules', 'Manage circulation rules'), ( 3, 'manage_circ_rules_from_any_libraries', 'Manage circ rules for any libraries'), - ( 3, 'manage_sysprefs', 'Manage global system preferences'), + ( 3, 'manage_sysprefs', 'Manage system preferences'), ( 3, 'manage_libraries', 'Manage libraries and library groups'), ( 3, 'manage_itemtypes', 'Manage item types'), ( 3, 'manage_auth_values', 'Manage authorized values'), diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc index e4c4cbe2a6..4925541539 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc @@ -146,7 +146,7 @@ ([% name | html %]) [%- CASE 'manage_sysprefs' -%] - Manage global system preferences + Manage system preferences ([% name | html %]) [%- CASE 'manage_libraries' -%] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt index 1ba35ac919..423d1f354c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt @@ -54,8 +54,8 @@ [% IF ( CAN_user_parameters_manage_sysprefs ) %]
-

Global system preferences

-

Manage global system preferences like MARC flavor, date format, administrator email, and templates.

+

System preferences

+

Manage system preferences like MARC flavor, date format, administrator email, and templates.

-- 2.39.5