]> git.koha-community.org Git - koha.git/commit
Bug 18150 - CanItemBeReserved doesn't work with (IndependentBranches AND ! canreserve...
authorNicolas Legrand <nicolas.legrand@bulac.fr>
Wed, 22 Feb 2017 09:11:18 +0000 (10:11 +0100)
committerKatrin Fischer <katrin.fischer.83@web.de>
Sun, 26 Mar 2017 20:29:58 +0000 (20:29 +0000)
commit4f57d8ccea9033cc3b6d17d69f3ac6d982877b6d
tree43df2868bd7c3d8b221e93ad83e40d14b3acc8f6
parentb3939f6f659fa3a409639441c24a5d5d6a73a6a3
Bug 18150 - CanItemBeReserved doesn't work with (IndependentBranches AND ! canreservefromotherbranches)

The variable $item used to be a hash, but at the end of the function,
it's a Koha object. As $item->{homebranch} doesn't yield anything and
should be $item->homebranch. It prevents people using different
branches without holds between branches from placing a hold on an item
they should be able to place hold on.

Test plan:

1. Before patch

  a. with IndependantBranches off
  b. try to place hold on an item you should be able to place hold on
  c. it should work
  d. put IndependantBranches on and canreservefromotherbranches off
  e. shouldn't work

2. after patches redo steps from (1) and everything should be working
fine.

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Note: Item is fetched twice, it's not necessary. But out of the scope of
this patch.

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit f79cf7930d887ea157fa64bb89fb0eb130b74aae)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
C4/Reserves.pm