From 1a2f6d10b962916c992540a4128c3738538b91f5 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Tue, 11 Dec 2018 15:15:57 +0000 Subject: [PATCH] Bug 21984: Pass param_name in pagination URL MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit To test: 1 - Create a report like: SELECT <>,<>,<> FROM items 2 - Run the report, enter 'CATS' and 'DOGS' 3 - Get results LIKE "CAT | DOG | CAT" 4 - Try to go to page 2 5 - FAIL! (last column is blank) 6 - Apply patch 7 - Run the repot, enter 'CATS' and 'DOGS' 8 - Verify first page looks right 9 - Go to page 2 10 - Results are correct! Signed-off-by: Kyle M Hall Signed-off-by: “Lucas Gass” Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens (cherry picked from commit f28a97034dd06b0f2b0e2e5fc56bea3878ffc717) Signed-off-by: Martin Renvoize (cherry picked from commit f7f5d6f2e2a6331ba2ae0671e10ce883f550dbb3) Signed-off-by: Lucas Gass --- reports/guided_reports.pl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl index 1a4ee50b18..af145c3da0 100755 --- a/reports/guided_reports.pl +++ b/reports/guided_reports.pl @@ -822,9 +822,13 @@ elsif ($phase eq 'Run this report'){ my $totpages = int($total/$limit) + (($total % $limit) > 0 ? 1 : 0); my $url = "/cgi-bin/koha/reports/guided_reports.pl?reports=$report_id&phase=Run%20this%20report&limit=$limit"; + if (@param_names) { + $url = join('&param_name=', $url, map { URI::Escape::uri_escape_utf8($_) } @param_names); + } if (@sql_params) { $url = join('&sql_params=', $url, map { URI::Escape::uri_escape_utf8($_) } @sql_params); } + $template->param( 'results' => \@rows, 'sql' => $sql, -- 2.39.5