From 5c42c2686c208b7c287b44da1743ac903b10f92a Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Tue, 17 Apr 2018 14:11:41 -0400 Subject: [PATCH] Bug 20598: Accruing fines not closed out by longoverdue.pl if WhenLostForgiveFine is not enabled Test Plan: 1) Ensure WhenLostForgiveFine is disabled 2) Create an overdue with a fine 3) Mark it lost with longoverdue.pl 4) Note it is still marked as an accruing fine 5) Apply this patch 6) Repeat steps 1-3 7) Note it is no longer an accruing fine! Signed-off-by: Maryse Simard Followed the test plan and it works. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens (cherry picked from commit 461a6f53b85becbefb18c0cb9356384a479aa9f1) (cherry picked from commit 180909e7a7400505c032b9f4fa186c016cf2a890) Signed-off-by: Fridolin Somers --- C4/Circulation.pm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 80db6b1561..7cc8038a22 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -3648,10 +3648,9 @@ sub LostItem{ if ( my $borrowernumber = $issues->{borrowernumber} ){ my $patron = Koha::Patrons->find( $borrowernumber ); - if (C4::Context->preference('WhenLostForgiveFine')){ - my $fix = _FixOverduesOnReturn($borrowernumber, $itemnumber, 1, 0); # 1, 0 = exemptfine, no-dropbox - defined($fix) or warn "_FixOverduesOnReturn($borrowernumber, $itemnumber...) failed!"; # zero is OK, check defined - } + my $fix = _FixOverduesOnReturn($borrowernumber, $itemnumber, C4::Context->preference('WhenLostForgiveFine'), 0); # 1, 0 = exemptfine, no-dropbox + defined($fix) or warn "_FixOverduesOnReturn($borrowernumber, $itemnumber...) failed!"; # zero is OK, check defined + if (C4::Context->preference('WhenLostChargeReplacementFee')){ C4::Accounts::chargelostitem($borrowernumber, $itemnumber, $issues->{'replacementprice'}, "Lost Item $issues->{'title'} $issues->{'barcode'}"); #FIXME : Should probably have a way to distinguish this from an item that really was returned. -- 2.39.5