From c54fe0c70fc2ae5fcec895bb6e9d7929303ce8ed Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Fri, 21 Jun 2019 08:51:15 -0400 Subject: [PATCH] Bug 23181: Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices Do to a simple semantic typo, the branches key will always be null for the tables key of the parameters for GetPreparedLetter. Test Plan: 0) Activate UseEmailReceipts 1) Attempt to use [% branch.branchname %] in the ACCOUNT_PAYMENT notice 2) Note it produces no output 3) Apply this patch 4) Make another payment 5) You should now see the branche's name! Signed-off-by: Katrin Fischer Also requires UseEmailReceipts to be activated. Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize (cherry picked from commit c4466e7d714d32808ee2e553320431005ec7cc69) Signed-off-by: Fridolin Somers (cherry picked from commit 73cf79940707ac9fcf74f5ea43e7711f058305f5) Signed-off-by: Hayley Mapley --- Koha/Account.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Koha/Account.pm b/Koha/Account.pm index eeb87a546c..2b7d78a9b2 100644 --- a/Koha/Account.pm +++ b/Koha/Account.pm @@ -268,7 +268,7 @@ sub pay { lang => $patron->lang, tables => { borrowers => $self->{patron_id}, - branches => $self->{library_id}, + branches => $library_id, }, substitute => { credit => $payment, -- 2.39.5