From dc1f51959ad1b7a5e7ca7e6259e0e42cc6260643 Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Wed, 31 May 2017 16:02:44 +0200 Subject: [PATCH] Bug 18706 - subfields to delete not disabled anymore in batch item modification In Tools > Batch item modification, one can click a checkbox to delete a subfield. This click use to disable the input to change the field value. This comes from the patch : Bug 13501: Move "Required" and checkbox after input/select Because input is found using JQuery next(). This patch replaces with $(this).parent().find("[name='field_value']"). Test plan : - Go to Tools > Batch item modification - Enter a barcode and submit - Click on a checkbox on a non-mandatory subfield => Without patch the input or select is not disabled => With patch the input or select is disabled - Submit => Check that subfield is deleted Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart (cherry picked from commit 7c9273be169ca4da47059aa152f8c6ea11137a52) Signed-off-by: Fridolin Somers --- .../intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt index e979494903..e774e95bae 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt @@ -22,13 +22,13 @@ $(document).ready(function(){ $("input[name='disable_input']").click(function() { var row = $(this).attr("id"); row = row.replace("row","hint"); - var subfield = $(this).next(); - if ($(this).is(":checked")){ + var editor = $(this).parent().find("[name='field_value']"); + if ($(this).is(":checked")) { $(this).val($(this).siblings("[name='subfield']").val()); - $(subfield).prop('disabled', true); + $(editor).prop('disabled', true); $("#"+row).html(_("This subfield will be deleted")); } else { - $(subfield).prop('disabled', false); + $(editor).prop('disabled', false); $("#"+row).html(""); } }); -- 2.39.5