From 07c91fba62803171e964ea3832e2876c257d8b66 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 3 Dec 2020 06:48:13 -0500 Subject: [PATCH] Bug 27068: Fetch libraries once for speed Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit fba0bda9a9899dd7efa157ea11ee68ef836a5159) Signed-off-by: Fridolin Somers (cherry picked from commit 99af6c24eb385f96167bd3ae49442d9aa0e66500) Signed-off-by: Andrew Fuerste-Henry --- C4/HoldsQueue.pm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm index 3f35c36760..a983382262 100755 --- a/C4/HoldsQueue.pm +++ b/C4/HoldsQueue.pm @@ -370,13 +370,15 @@ sub GetItemsAvailableToFillHoldRequestsForBib { =cut +our $libraries = {}; sub _checkHoldPolicy { my ($item, $request) = @_; return 0 unless $item->{holdallowed}; return 0 if $item->{holdallowed} == 1 && $item->{homebranch} ne $request->{borrowerbranch}; - my $library = Koha::Libraries->find($item->{homebranch}); + $libraries->{$item->{homebranch}} ||= Koha::Libraries->find($item->{homebranch}); + my $library = $libraries->{$item->{homebranch}}; return 0 if $item->{'holdallowed'} == 3 && !$library->validate_hold_sibling({branchcode => $request->{borrowerbranch}}); @@ -386,7 +388,8 @@ sub _checkHoldPolicy { return 0 if $hold_fulfillment_policy eq 'homebranch' && $request->{branchcode} ne $item->{$hold_fulfillment_policy}; return 0 if $hold_fulfillment_policy eq 'holdingbranch' && $request->{branchcode} ne $item->{$hold_fulfillment_policy}; - my $patronLibrary = Koha::Libraries->find($request->{borrowerbranch}); + $libraries->{$request->{borrowerbranch}} ||= Koha::Libraries->find($request->{borrowerbranch}); + my $patronLibrary = $libraries->{$request->{borrowerbranch}}; return 0 if $hold_fulfillment_policy eq 'patrongroup' && !$patronLibrary->validate_hold_sibling({branchcode => $request->{branchcode}}); -- 2.39.5