]> git.koha-community.org Git - koha.git/commit
Bug 38394: Remove existing try/catch and say_failure from DB revs
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 7 Nov 2024 14:10:01 +0000 (15:10 +0100)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Thu, 7 Nov 2024 15:29:20 +0000 (16:29 +0100)
commit4ccdb714ec1c5488b64086bfc8ac4d9bb7b0d291
tree53bc4d2bc9c29713e34a5585d935f7e26c9953b5
parentfe495d19dfc138fc99f7c77e41a33c77521cb738
Bug 38394: Remove existing try/catch and say_failure from DB revs

On bug 37895 we have failed to propose a solution to encapsulate exceptions and rethrow them.

Until this is ready we should not try/catch and so use say_failure from our DB revs.

We want to stop the DB update process when something is wrong. In those
try/catch we are actually continuing even if something bad happens.

As RaiseError is set on the dbh, say_failure statements will never be
reached.

Test plan:
checkout origin/24.05.0
reset_all
checkout main + this patch
updatedatabase

Everything should run fine.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
61 files changed:
installer/data/mysql/atomicupdate/skeleton.pl
installer/data/mysql/db_revs/231200044.pl
installer/data/mysql/db_revs/231200051.pl
installer/data/mysql/db_revs/231200054.pl
installer/data/mysql/db_revs/231200059.pl
installer/data/mysql/db_revs/231200060.pl
installer/data/mysql/db_revs/231200061.pl
installer/data/mysql/db_revs/240600001.pl
installer/data/mysql/db_revs/240600002.pl
installer/data/mysql/db_revs/240600003.pl
installer/data/mysql/db_revs/240600004.pl
installer/data/mysql/db_revs/240600005.pl
installer/data/mysql/db_revs/240600006.pl
installer/data/mysql/db_revs/240600007.pl
installer/data/mysql/db_revs/240600008.pl
installer/data/mysql/db_revs/240600009.pl
installer/data/mysql/db_revs/240600010.pl
installer/data/mysql/db_revs/240600011.pl
installer/data/mysql/db_revs/240600012.pl
installer/data/mysql/db_revs/240600013.pl
installer/data/mysql/db_revs/240600014.pl
installer/data/mysql/db_revs/240600015.pl
installer/data/mysql/db_revs/240600016.pl
installer/data/mysql/db_revs/240600017.pl
installer/data/mysql/db_revs/240600018.pl
installer/data/mysql/db_revs/240600019.pl
installer/data/mysql/db_revs/240600020.pl
installer/data/mysql/db_revs/240600021.pl
installer/data/mysql/db_revs/240600022.pl
installer/data/mysql/db_revs/240600023.pl
installer/data/mysql/db_revs/240600024.pl
installer/data/mysql/db_revs/240600025.pl
installer/data/mysql/db_revs/240600026.pl
installer/data/mysql/db_revs/240600027.pl
installer/data/mysql/db_revs/240600028.pl
installer/data/mysql/db_revs/240600029.pl
installer/data/mysql/db_revs/240600030.pl
installer/data/mysql/db_revs/240600031.pl
installer/data/mysql/db_revs/240600032.pl
installer/data/mysql/db_revs/240600033.pl
installer/data/mysql/db_revs/240600034.pl
installer/data/mysql/db_revs/240600036.pl
installer/data/mysql/db_revs/240600037.pl
installer/data/mysql/db_revs/240600038.pl
installer/data/mysql/db_revs/240600039.pl
installer/data/mysql/db_revs/240600040.pl
installer/data/mysql/db_revs/240600041.pl
installer/data/mysql/db_revs/240600042.pl
installer/data/mysql/db_revs/240600043.pl
installer/data/mysql/db_revs/240600044.pl
installer/data/mysql/db_revs/240600045.pl
installer/data/mysql/db_revs/240600046.pl
installer/data/mysql/db_revs/240600047.pl
installer/data/mysql/db_revs/240600048.pl
installer/data/mysql/db_revs/240600049.pl
installer/data/mysql/db_revs/240600050.pl
installer/data/mysql/db_revs/240600051.pl
installer/data/mysql/db_revs/240600052.pl
installer/data/mysql/db_revs/240600053.pl
installer/data/mysql/db_revs/240600054.pl
installer/data/mysql/db_revs/240600055.pl