]> git.koha-community.org Git - koha.git/commit
Bug 14440: get_template_and_user can not have an empty template_name (opac-ratings.pl)
authorFridolin Somers <fridolin.somers@biblibre.com>
Tue, 23 Jun 2015 15:45:30 +0000 (17:45 +0200)
committerMason James <mtj@kohaaloha.com>
Sat, 25 Jul 2015 13:20:10 +0000 (01:20 +1200)
commit6a4f3bcd0e9d01d1370870260923ab537facd319
treeab2d0427bb9fb13c9857ca4996e34e51c1703d81
parent8f9db880ee6d1d8f1f0d4c47a067e77a1c7f55e4
Bug 14440: get_template_and_user can not have an empty template_name (opac-ratings.pl)

Since Bug 14408, the method get_template_and_user can not have an empty template_name.
Pages calling with an empty value should use C4::Auth::checkauth()

This patch corrects opac/opac-ratings.pl

Test plan :
- Apply patch
- Set sysopref OpacStarRatings to 'results and details'
- Disable Javascipt on your browser (otherwise it will use ajax)
- Login at OPAC
- Go to a record
- Click on a button left of 'Rate me' to choose a rating, ie 4
- Click on 'Rate me'
=> The page is reloaded and you see 'your rating: 4'
- Loggout from OPAC
- Try to access URL : http://<serveur>/cgi-bin/koha/opac-ratings.pl
=> You see the loggin page

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
(cherry picked from commit f1acb5615d0cbcba5db5b84e12fbad3d41454347)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 3d8af819a84847b35ad08e62ba137d3febd878dd)

Conflicts:
opac/opac-ratings.pl

Signed-off-by: Liz <wizzyrea@gmail.com>
Conflicts:
opac/opac-ratings.pl
opac/opac-ratings.pl