From 5e7263f16670a4fa59409cdeddaee88a20def2de Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Fri, 10 Feb 2023 23:57:44 +0100
Subject: [PATCH] Bug 32525: Standardize labels on list of ILL requests and ILL
 request details page

This changes some labels so they match up between the
ILL requests list and the detail page of a request:

* 'View biblio details' to 'View bibliographic record'
* 'View borrower details' to 'View patron details'
* 'Branch' table heading to 'Library' in list view
* 'Request number' to 'Request ID' in list view
* 'Type' to 'Request type' in detail view
* 'Bibliographic record' to 'Bibliographic record ID"

To test:
*  Install a backend and activate the ILL module, see:
   https://wiki.koha-community.org/wiki/ILL_backends
*  Add a new request
*  Compare the table headings with the labels on the detail page
*  Apply patch
*  Verify listed changes from above

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 2dfafa5b9d3c8440d0f823d34661fbeeb0291b60)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
(cherry picked from commit 4b5163f25a9d654308cdd64d5bfd7ca80419d775)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit d52dae84f289775af3065332f2e942e6f210786b)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
---
 .../prog/en/includes/ill-list-table-strings.inc             | 4 ++--
 koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc | 6 +++---
 koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table-strings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table-strings.inc
index 4d217023c2..7734384155 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table-strings.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table-strings.inc
@@ -1,7 +1,7 @@
 <!-- ill-list-table-strings.inc -->
 <script>
-    var ill_borrower_details = _("View borrower details");
-    var ill_biblio_details = _("View biblio details");
+    var ill_borrower_details = _("View patron details");
+    var ill_biblio_details = _("View bibliographic record");
     var ill_statuses = {
         new: _("New request"),
         req: _("Requested"),
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc
index 7cf2987ab6..14b6485ad2 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc
@@ -14,11 +14,11 @@
                 <th scope="col">Volume</th>
                 <th scope="col">Year</th>
                 <th scope="col">Pages</th>
-                <th scope="col">Type</th>
+                <th scope="col">Request type</th>
                 <th scope="col">Order ID</th>
                 <th scope="col">Patron</th>
-                <th scope="col">Bibliographic record</th>
-                <th scope="col">Branch</th>
+                <th scope="col">Bibliographic record ID</th>
+                <th scope="col">Library</th>
                 <th scope="col">Status</th>
                 <th scope="col" class="placed">&nbsp;</th>
                 <th scope="col" class="placed_formatted">Placed on</th>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
index e3c15d5de6..188f0dcf77 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
@@ -447,7 +447,7 @@
                                     <input name="price_paid" id="price_paid" type="text" value="[% request.price_paid | html %]">
                                 </li>
                                 <li class="req_id">
-                                    <label class="req_id">Request number:</label>
+                                    <label class="req_id">Request ID:</label>
                                     [% request.id_prefix _ request.illrequest_id | html %]
                                 </li>
                                 <li class="notesstaff">
@@ -662,7 +662,7 @@
                                         [% IF request.price_paid %][% request.price_paid | $Price %][% ELSE %]<span>N/A</span>[% END %]
                                     </li>
                                     <li class="req_id">
-                                        <span class="label req_id">Request number:</span>
+                                        <span class="label req_id">Request ID:</span>
                                         [% request.id_prefix _ request.illrequest_id | html %]
                                     </li>
                                     <li class="notesstaff">
-- 
2.39.5