From 85afecd491b08152bd140b67381e75bffe47561e Mon Sep 17 00:00:00 2001
From: =?utf8?q?Johanna=20R=C3=A4is=C3=A4?= <johanna.raisa@gmail.com>
Date: Fri, 9 Aug 2024 08:58:31 +0300
Subject: [PATCH] Bug 37591: Fix moredetail.tt performance issue

This patch fixes the performance issue in moredetail.tt by removing the
unnecessary call of checkout_renewals table.

To test:
1. Create lot of checkouts and renewals for a record.
2. Open the moredetail page for the record.
3. Check the timing of the page load.
4. Apply the patch and check the timing of the page load again.
5. The page load should be faster after applying the patch.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 5c41c1c657eba6be37bd8ca4622fdc9eda658fcd)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../intranet-tmpl/prog/en/modules/catalogue/moredetail.tt   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
index 6ef020cecb..11878892eb 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
@@ -193,11 +193,11 @@
                                                 [% END %]
                                             [% END %]
                                         </li>
-                                        [% IF ITEM_DAT.object.checkout.renewals.count && ITEM_DAT.object.checkout %]
+                                        [% IF ITEM_DAT.object.checkout.renewals_count %]
                                             <li>
                                                 <span class="label">Current renewals:</span>
-                                                [% ITEM_DAT.object.checkout.renewals.count | html %]
-                                                    [ <a class="checkout_renewals_view" data-renewals="[% ITEM_DAT.object.checkout.renewals.count | html | html %]" data-issueid="[% ITEM_DAT.object.checkout.id | html %]" href="#">View</a> ]
+                                                [% ITEM_DAT.object.checkout.renewals_count | html %]
+                                                    [ <a class="checkout_renewals_view" data-renewals="[% ITEM_DAT.object.checkout.renewals_count | html | html %]" data-issueid="[% ITEM_DAT.object.checkout.id | html %]" href="#">View</a> ]
                                             </li>
                                         [% END %]
                                         [% IF itemlostloop %]
-- 
2.39.5