From a85086d8278b3c0b5ad578c3af7b0e70637a47be Mon Sep 17 00:00:00 2001 From: Phil Ringnalda Date: Wed, 26 Jun 2024 20:19:21 -0700 Subject: [PATCH] Bug 37197: Reports option to send to batch patron modification needs to use POST When you have an SQL report that selects cardnumber from borrowers, you get a menuitem to send the results to Batch patron modification. Currently that fails with a message about no card numbers or borrowernumbers given, because it tries to do a GET with the op show, when modborrowers.pl is expecting a POST with the op cud-show. Test plan: 1. Without the patch, Reports - Create from SQL - name it and paste select cardnumber from borrowers in the SQL textarea and save, then Run report. 2. Above the results is a "Batch operations with 20 visible records" menu, choose Batch patron modification 3. Note that instead of modifying the records, you're stuck with a message saying "No patron card numbers or borrowernumbers given." even though there's a whole string of them in the URL. 4. Apply patch, refresh the page with the results (oddly, no apparent need to even restart_all), and choose the menuitem again, but this time with a successful result. Signed-off-by: David Nind Signed-off-by: Matt Blenkinsop Signed-off-by: Martin Renvoize --- .../prog/en/modules/reports/guided_reports_start.tt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt index c177c6740b..b039bd5cf9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ -999,8 +999,9 @@ [% END %] -
- + + [% INCLUDE 'csrf-token.inc' %] + [% # Preserve the whitespace of the following textarea in order to format the values correctly %] [%- cardnumbers = PROCESS batch_list results=results batch_type='cardnumber' | trim | html %] [% IF cardnumbers %] -- 2.39.5