From c724a3db1d83447459b488ee7911a821720a5da1 Mon Sep 17 00:00:00 2001 From: Didier Gautheron Date: Wed, 8 Apr 2020 09:33:44 +0200 Subject: [PATCH] Bug 25167: Fix to a fix wrong inventory results MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Test plan : - Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, for example 'NOTFORLOAN' - Create a new value in this category, for example '9' - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='A-1' and notforloan=0 - Create an item with barcode='000AAA2', callnumber='A-2' and notforloan=9 - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'A-0' and 'A-9' - Check 'Compare barcodes list to results' - Submit=> without patch, you get no warnings - Redo the same inventory but with checking items.notforloan 'For loan' (using the browser back page is ok) - submit => still no warning, Bug 000AAA2 must be listed it's not 'For loan' - Apply patch, repeat, with tems.notforloan 'For loan' checked you get the right warning Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 1181402eee9392fddf0e3a64de5941880485c074) Signed-off-by: Lucas Gass --- tools/inventory.pl | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/inventory.pl b/tools/inventory.pl index 88ec223323..caeb0229b9 100755 --- a/tools/inventory.pl +++ b/tools/inventory.pl @@ -118,6 +118,13 @@ for my $authvfield (@$statuses) { } } +# if there's a list of not for loans types selected use it rather than +# the full set. +if ($staton->{'items.notforloan'}) { + my @l = @{$staton->{'items.notforloan'}}; + @notforloans = @l if scalar @l > 0; +} + my @class_sources = Koha::ClassSources->search({ used => 1 }); my $pref_class = C4::Context->preference("DefaultClassificationSource"); -- 2.39.5