]> git.koha-community.org Git - koha.git/commit
Bug 10511: fix message preference form glitch concerning phone notifications
authorKyle M Hall <kyle@bywatersolutions.com>
Wed, 26 Jun 2013 20:40:09 +0000 (16:40 -0400)
committerBernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Sat, 14 Sep 2013 18:31:25 +0000 (15:31 -0300)
commit645945a339f9a01a31a08bc8c14e4c31a289234d
treef57692603d74633e6595f4f6e44b7eb32226cdfa
parent056c2feeaea534c1d1ba0556f5b4464d7da84dee
Bug 10511: fix message preference form glitch concerning phone notifications

An error in the onclick for phone notices causes the "Do not notify"
checkbox to be checked when the phone checkbox is checked. Also,
checking "Do not notify" does not uncheck the phone checkbox.

Test plan:
1) Enable TalkingTechItivaPhoneNotification
2) Browse to the new patron screen ( memberentry.pl )
3) In the patron messaging preferences check the Phone checkbox
4) Not the "do not notify" checkbox is then checked
5) Uncheck the "do not notify" checkbox, and check the Email checkbox as well
6) Now check the "do not notify" checkbox, note the Phone checkbox remains checked
7) Apply this patch
8) Repeat steps 3-6, noting the odd behavior is no longer present

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit e608f4d48c09e025fc10d47668bb40c0d3d686a7)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Works as expected. EnhancedMessagingPreferences needs to be set to reproduce.
(cherry picked from commit 475bb4e6bf79a21fed261e91ed466950374636ec)
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
(cherry picked from commit 475bb4e6bf79a21fed261e91ed466950374636ec)
koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc