]> git.koha-community.org Git - koha.git/commit
Bug 18736: (QA follow-up) Change to signed, add large int test
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 28 Sep 2018 09:20:49 +0000 (11:20 +0200)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 25 Mar 2019 14:29:31 +0000 (14:29 +0000)
commit545551b173a49592f88727cbf032f27845891368
treea041992d2d5da20cb1aac9966faf05536c24158b
parentb67eb18c8a433e42029f536c18e0fae617bdc12f
Bug 18736: (QA follow-up) Change to signed, add large int test

[1] Add trivial subtest in t/Number/Price.t
Checking a negative number and a large number for the MAX_INT change.
Note: Confusing to have t/Prices.t too.

[2] Change UNSIGNED to SIGNED in get_rounding_sql. Although I did not spot
problems with negative prices, we theoretically could while casting.
cast(-2 as unsigned) == 18446744073709551614

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 2f5e839bf780955d228c9672abce9d6e5ad1aedf)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
C4/Acquisition.pm
t/Number/Price.t