From 6c080063ba9c79b69bc08123936037f0ad654663 Mon Sep 17 00:00:00 2001 From: Petro Vashchuk Date: Fri, 14 Jan 2022 11:57:39 +0200 Subject: [PATCH] Bug 29883: avoid uninitialized value warn in GetAuthorisedValues sub GetAuthorisedValues is defined with optional parameter $category but it is instantly interpolated without preventing "Use of uninitialized value $category in concatenation (.) or string at .../C4/Koha.pm line 491." warning. As category param is optional, we can avoid throwing that warn as it is something that can happen and is not an actual error: C<$category> returns authorized values for just one category (optional). Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 44e126bcc7fae369e13c533eea79f00ef41f2ff1) Signed-off-by: Lucas Gass (cherry picked from commit 36cbd69763dc8e8162781ee22bc7d5e234443b9d) Signed-off-by: Arthur Suzuki --- C4/Koha.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/Koha.pm b/C4/Koha.pm index 681d6ff38f..89376b0b4a 100644 --- a/C4/Koha.pm +++ b/C4/Koha.pm @@ -482,10 +482,10 @@ C<$opac> If set to a true value, displays OPAC descriptions rather than normal o =cut sub GetAuthorisedValues { - my ( $category, $opac ) = @_; + my $category = shift // ''; # optional parameter + my $opac = shift ? 1 : 0; # normalise to be safe # Is this cached already? - $opac = $opac ? 1 : 0; # normalise to be safe my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : ""; my $cache_key = -- 2.39.5