From 0bc0aa708c5903c8ae2b7c45643600d0fc59ae03 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi>
Date: Tue, 25 Aug 2020 12:10:20 +0000
Subject: [PATCH] Bug 16357: (QA follow-up) Only initialize Log4perl module

Koha::Logger->get was setting up some extra variables
which are not used nor needed for the Plack::Middleware::Log4perl
middleware to work. According to documentation at
https://metacpan.org/pod/Plack::Middleware::Log4perl#SYNOPSIS
only running Log::Log4perl::init, enabling Log4Perl middleware and
setting up the logging category is enough. Koha::Logger->_init runs the
Log::Log4perl::init and enabling and setting category is handled
directly in plack.psgi.

Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 debian/templates/plack.psgi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/templates/plack.psgi b/debian/templates/plack.psgi
index 32d17940ae..7bfb34fb68 100644
--- a/debian/templates/plack.psgi
+++ b/debian/templates/plack.psgi
@@ -66,7 +66,7 @@ my $apiv1  = builder {
     $server->to_psgi_app;
 };
 
-Koha::Logger->get;
+Koha::Logger->_init;
 
 builder {
     enable "ReverseProxy";
-- 
2.39.5