From 8005648d21f7c29ab7225487c2c64b710265706a Mon Sep 17 00:00:00 2001 From: Florian Bontemps Date: Wed, 29 Jun 2022 15:18:17 +0000 Subject: [PATCH] Bug 31067: Fixing missing permission check This patch just fixes a missing permission on the intranet main page. Currently, the Additional Content modules allows people to edit, modify or create new additional content just by checking if they have any tool permission at all, and not the right one. To test: 1 - From the staff client, create a news article for the intranet. 2 - Create (or use) an additional staff patron, giving them the necessary permissions to access the intranet, but no tool permission. 3 - Using another browser (or incognito mode), log on the intranet page with your new staff account, you should be able to see the news content, but not edit or delete it. That's the expected behavior. 4 - From your main admin account, give your test account the edit_additional_contents permission. 5 - Your test account should now be able to edit/delete the news content. This is also expected behavior. 6 - Using the main account again, remove this time the edit_additional_contents but add any other subtool permission (edit_calendar is a good one for instance) 7 - Repeat step 5 and confirm that your test account can still edit or delete the news content. This shouldn't happen. 8 - Apply patch 9 - Repeat steps 4-6, and confirm that your test account can now only edit or delete news content if they have the edit_additional_contents permission enabled. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit e3faa4d66ba281125be437a971d1549ba8179ec3) Signed-off-by: Lucas Gass (cherry picked from commit 692c054a736c8eb6808a1017f0a9f565677a0860) Signed-off-by: Arthur Suzuki --- koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt index 45943d3608..797b58b77c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt @@ -32,7 +32,7 @@

[% koha_new.title | html %]

[% koha_new.content | $raw %]

Posted on [% koha_new.published_on | $KohaDates %][% IF( show_author && koha_new.author ) %] by [% INCLUDE 'patron-title.inc' patron=koha_new.author %]
[% END %] - [% IF ( CAN_user_tools ) %] + [% IF ( CAN_user_tools_edit_additional_contents ) %] Edit | Delete | New -- 2.39.5